Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translation memory re-build shows wrong error if component does not exist #7579

Closed
2 tasks done
rhofer opened this issue May 2, 2022 · 1 comment
Closed
2 tasks done
Assignees
Milestone

Comments

@rhofer
Copy link
Contributor

rhofer commented May 2, 2022

Describe the issue

This is a follow-up (bug report) to #7347

Rebuild TM: When trying the rebuild button under a certain project, where the belonging component has been moved to another project (means not existant in this project anymore), a permission denied message is shown:

image

It took me quite a while to figure out why this permission denied is shown, what actually has nothing to do with permissions.

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

  1. Go to "Project" > Manage > Translation memory
  2. Pick a memory from a component which is still listed as TM under this project BUT the component itself has been moved to another project, meanwhile. Press TM "rebuild" button.
  3. Permission denied message is shown > not really useful error message.

Expected behavior

When trying to rebuild a TM where the component does not exist anymore or has been moved, please

  • show appropriate error message, or
  • besides error message, offer to delete this TM in same dialogue

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

Docker container

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response

@nijel nijel self-assigned this May 3, 2022
@nijel nijel added this to the 4.13 milestone May 3, 2022
@nijel nijel closed this as completed in a2c077d May 3, 2022
@github-actions
Copy link

github-actions bot commented May 3, 2022

The issue you have reported is now resolved. If you don’t feel it’s right, please follow its labels to get a clue for further steps.

  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

nijel added a commit that referenced this issue May 4, 2022
- Do not offer rebuild for file origins
- Do not offer rebuild for removed components
- Add rebuild option for components without memory entries

Fixes #7579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants