Confirmation on user deletion

[wilcopots]

Describe the problem

On the user detail page (/user/[username]/#edit), on the bottom of the page there is an option to delete the user, via button 'Delete'.
This button is right next to the 'Save' button.

If for any reason you miss-click on 'Save', and thereby click on 'Delete'. The user is deleted immediately and not able to restore.

Describe the solution you'd like

It would be ideally if there is a confirmation page after request for deletion, likewise the same as there is for deleting a component or project. In that case you won't accidentally irreversible delete the user.

Describe alternatives you've considered

No response

Screenshots

Additional context

Using Weblate 4.13.1

[github-actions]

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

[shashwatpandeyvns]

Hi,
I would like contribute to the project. How can start this journey? Please, Enlighten me.

[nijel]

You're welcome to contribute!

The current delete button is here:

weblate/weblate/templates/accounts/user.html

Lines 291 to 296 in c8f5079

	<form method="post">
	{% csrf_token %}
	{{ form|crispy }}
	<input type="submit" value="{% trans "Save" %}" class="btn btn-primary" />
	<input type="submit" name="remove_user" value="{% trans "Delete" %}" class="btn btn-danger" />
	</form>

It needs to include a confirmation popup like it is done here for removing a user from a project:

weblate/weblate/templates/trans/project-access-row.html

Lines 44 to 59 in c8f5079

	<div class="modal fade" tabindex="-1" role="dialog" id="delete_user_{{ user.id }}">
	<div class="modal-dialog" role="document">
	<div class="modal-content">
	<div class="modal-header">
	<button type="button" class="close" data-dismiss="modal" aria-label="{% trans "Close" %}"><span aria-hidden="true">&times;</span></button>
	<h4 class="modal-title">{% trans "Are you absolutely sure?" %}</h4>
	</div>
	<div class="modal-body">
	{% blocktrans with user=user.username %}This will remove <b>{{ user }}</b> access to this project.{% endblocktrans %}
	</div>
	<div class="modal-footer">
	<input type="submit" class="btn btn-danger" value="{% trans "Remove" %}" />
	</div>
	</div><!-- /.modal-content -->
	</div><!-- /.modal-dialog -->
	</div><!-- /.modal -->

[shashwatpandeyvns]

I was trying to install Weblate on wsl for testing purposes, but it failed every time with - ERROR: Could not build wheels for borgbackup which use PEP 517 and cannot be installed directly. Any Idea what's going on here?

[nijel]

Maybe you're missing some of the system dependencies, please check corresponding distro guide at https://docs.weblate.org/en/latest/admin/install.html

[DiegoCaraballo]

Hello @nijel how are you?
I would like to contribute.
Can I start with this?
Regards!

[nijel]

@DiegoCaraballo Yes, contributions are always welcome!

[prakhar1144]

Hey all,
I have started working on this issue.

[alexjensen2002]

Oh, my apologies @prakhar1144 I forgot to say I started working on this earlier. I'm pretty much done with it, though I'm not entirely clear on how or whether I need to do unit tests/etc for this, since it's just an HTML change.

@nijel how would I go about making a pull request and/or getting feedback on if my code is ready to merge?

edit: here is the code that I have right now:
alexjensen2002@526ab31
visual of what happens when you press the delete button now:

[alexjensen2002]

Oh, oops, I didn't see the compare across forks button before so I thought that I couldn't make a PR for some reason haha.

I wasn't sure how to do unit tests or squash commits, so for now this is just a draft PR.
I'm using WSL and Docker for my setup, by the way, so if you have any way to help me there that would be appreciated. When I try to use rundev.sh to test it doesn't find any tests, so I assume I'm missing some sort of setup.

[github-actions]

Thank you for your report; the issue you have reported has just been fixed.

• In case you see a problem with the fix, please comment on this issue.
• In case you see a similar problem, please open a separate issue.
• If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.