Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin install documentation still mentions template loader section that was removed #8087

Closed
2 tasks done
Bubu opened this issue Sep 7, 2022 · 3 comments · Fixed by #8088
Closed
2 tasks done

admin install documentation still mentions template loader section that was removed #8087

Bubu opened this issue Sep 7, 2022 · 3 comments · Fixed by #8088
Assignees
Labels
documentation Improvements or additions to the documentation. good first issue Opportunity for newcoming contributors.
Milestone

Comments

@Bubu
Copy link
Contributor

Bubu commented Sep 7, 2022

Describe the issue

https://docs.weblate.org/en/latest/admin/install.html?highlight=loader#template-loading mentions:

You can configure it using the following snippet (the loaders setting is important here):

but the loaders setting was removed. (I think it's all default now, so maybe the whole section can be removed? But maybe it just needs some rephrasing.)

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

No response

Expected behavior

No response

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

Other

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response

@nijel nijel added documentation Improvements or additions to the documentation. good first issue Opportunity for newcoming contributors. labels Sep 7, 2022
@github-actions
Copy link

github-actions bot commented Sep 7, 2022

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

@nijel
Copy link
Member

nijel commented Sep 7, 2022

Yes, it can be removed, it's default in Django now

Bubu added a commit to Bubu/weblate that referenced this issue Sep 7, 2022
The section is no longer relevant as django defaults are now exactly what this was proposing.

Closes WeblateOrg#8087
@nijel nijel added this to the 4.14.1 milestone Sep 12, 2022
nijel pushed a commit that referenced this issue Sep 12, 2022
The section is no longer relevant as django defaults are now exactly what this was proposing.

Closes #8087
@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

nijel added a commit that referenced this issue Sep 12, 2022
Django now does this automaticaly, see #8088 and #8087.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to the documentation. good first issue Opportunity for newcoming contributors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants