Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make approved translations string editable #8196

Closed
yangyangdaji opened this issue Oct 8, 2022 · 4 comments
Closed

Make approved translations string editable #8196

yangyangdaji opened this issue Oct 8, 2022 · 4 comments

Comments

@yangyangdaji
Copy link
Contributor

yangyangdaji commented Oct 8, 2022

Replaced by #8198

Describe the problem

As proposed at GradienceTeam/Gradience#616 (comment)

When an Incorrect is found in the translation string of an annotation. It can be changed at any time. Instead of changing the translation source file
Screenshot_20221008_184401

Screenshot_20221008_065409_edit_1522055337267

Describe the solution you'd like

Make approved translations string editable

@yangyangdaji yangyangdaji changed the title Make approved translations editable Make approved translations string editable Oct 8, 2022
@Geeyun-JY3
Copy link
Collaborator

Geeyun-JY3 commented Oct 9, 2022

No. Making translations uneditable is what approved translations are for.
The issue here is why these translations are de facto approved in Weblate while they are shown as Translated in the History tab.
image

And I think you should ask the project maintainer whether some configurations about the review workflow are set.

@yangyangdaji
Copy link
Contributor Author

ok

@yangyangdaji yangyangdaji closed this as not planned Won't fix, can't repro, duplicate, stale Oct 9, 2022
@github-actions
Copy link

github-actions bot commented Oct 9, 2022

The issue you have reported is now resolved. If you don’t feel it’s right, please follow its labels to get a clue for further steps.

  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

@yangyangdaji
Copy link
Contributor Author

Replaced by #8198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants