Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(show differences) The text is highlighted incorrectly #8257

Closed
2 tasks done
yangyangdaji opened this issue Oct 22, 2022 · 3 comments
Closed
2 tasks done

(show differences) The text is highlighted incorrectly #8257

yangyangdaji opened this issue Oct 22, 2022 · 3 comments
Assignees
@nijel
Labels
bug Something is broken.
Milestone
4.14.2

Comments

@yangyangdaji
Copy link
Contributor

yangyangdaji commented Oct 22, 2022 •
edited

Describe the issue

The text is highlighted incorrectly

1. The added text is not highlighted

Screenshot_20221022_221721_edit_53780273445439

2. Strikethrough color inconsistency

Screenshot_20221022_173610_edit_37724510066118

Example

1

https://hosted.weblate.org/translate/jamulus/windows-installer/zh_Hans/?checksum=9f211635d90572e3

2

https://hosted.weblate.org/projects/jamulus/windows-installer/zh_Hans/#history

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

How do you run Weblate?

weblate.org service

Weblate versions

Weblate 4.14.2-dev
@yangyangdaji yangyangdaji changed the title bug in show differences (show differences) Highlighting is abnormal Oct 22, 2022
@yangyangdaji yangyangdaji changed the title (show differences) Highlighting is abnormal (show differences) The text is highlighted incorrectly Oct 22, 2022
@nijel nijel added the bug Something is broken. label Oct 24, 2022
@nijel nijel self-assigned this Oct 24, 2022
@nijel nijel added this to the 4.14.2 milestone Oct 24, 2022
@nijel nijel closed this as completed in 8a1f8ab Oct 24, 2022
@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

@Geeyun-JY3
Copy link
Collaborator

@nijel Still can reproduce the strikethrough color issue in suggestion-related events
Example: https://hosted.weblate.org/translate/debian-handbook/14_security/zh_Hans/?checksum=5f15c91d08b7638d#history

nijel added a commit that referenced this issue Nov 9, 2022
@nijel
css: Reset color for ins/del tags
cbde36b 
Fixes #8257
@nijel
Copy link
Member

nijel commented Nov 9, 2022

That should be fixed in cbde36b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nijel nijel

Labels
bug Something is broken.
Projects
None yet
Milestone
4.14.2
Development

No branches or pull requests
3 participants
@nijel @Geeyun-JY3 @yangyangdaji