Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"other occurrences" incorrect context display #8502

Closed
2 tasks done
tomkolp opened this issue Dec 17, 2022 · 10 comments
Closed
2 tasks done

"other occurrences" incorrect context display #8502

tomkolp opened this issue Dec 17, 2022 · 10 comments
Assignees
Labels
enhancement Adding or requesting a new feature.
Milestone

Comments

@tomkolp
Copy link
Contributor

tomkolp commented Dec 17, 2022

Describe the issue

Context is displayed incorrectly in the "other occurrences tab".

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

  1. Go to other occurrences tab
  2. See error

Expected behavior

Correct context display (as before).

Screenshots

image

Exception traceback

No response

How do you run Weblate?

Docker container

Weblate versions

No response

Weblate deploy checks

No response

Additional context

4.15-dev — a128a91

@nijel
Copy link
Member

nijel commented Dec 17, 2022

What is wrong on that? There used to be no context display here before.

@tomkolp
Copy link
Contributor Author

tomkolp commented Dec 17, 2022

the context is vertical

@nijel
Copy link
Member

nijel commented Dec 17, 2022

Because the screen is too small for that. The text is vertical as well.

@tomkolp
Copy link
Contributor Author

tomkolp commented Dec 17, 2022

Unfortunately I don't have a screenshot. The context was horizontal. I guess before you could scroll the screen to the right if something didn't fit.

@nijel
Copy link
Member

nijel commented Dec 18, 2022

The context was not displayed here before, it was added in 2144cf2.

@tomkolp
Copy link
Contributor Author

tomkolp commented Dec 18, 2022

That's why I couldn't find screenshots. Is it possible to better adjust the display of context? If not, you can close the issue.

@nijel
Copy link
Member

nijel commented Dec 19, 2022

With removed wrapping, the text will need horizontal scrolling:

image

I have no clue what is better, but we definitely need to be able to wrap context when it's too long.

@tomkolp
Copy link
Contributor Author

tomkolp commented Dec 19, 2022

Now you have to scroll right anyway.
image

image

@github-actions
Copy link

This issue has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

@github-actions github-actions bot added the wontfix Nobody will work on this. label Dec 30, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 4, 2023
@orangesunny orangesunny removed the wontfix Nobody will work on this. label Mar 29, 2023
@orangesunny orangesunny self-assigned this Mar 29, 2023
@orangesunny orangesunny added this to the 4.17 milestone Mar 29, 2023
@nijel nijel self-assigned this Apr 12, 2023
@nijel nijel added the enhancement Adding or requesting a new feature. label Apr 12, 2023
@nijel nijel reopened this Apr 12, 2023
@nijel nijel closed this as completed in 27f75ba Apr 12, 2023
@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

@nijel nijel mentioned this issue May 29, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants