Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make read-only strings blue #8949

Closed
throwaway-d opened this issue Mar 19, 2023 · 15 comments
Closed

Make read-only strings blue #8949

throwaway-d opened this issue Mar 19, 2023 · 15 comments
Labels
enhancement Adding or requesting a new feature. undecided These features might not be implemented. Can be prioritized by sponsorship. wontfix Nobody will work on this.

Comments

@throwaway-d
Copy link

throwaway-d commented Mar 19, 2023

Describe the problem

Darkempire78/OpenCalc#197

It would be easy to differ with editable strings.

Describe the solution you'd like

Just read the title

Describe alternatives you've considered

No response

Screenshots

image
image

Additional context

I'm very newbie to reporting issues on this project. This project looks very big and complex. I hope the issue description is good enough.

@github-actions
Copy link

This issue has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

@github-actions github-actions bot added the wontfix Nobody will work on this. label Mar 30, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 4, 2023
@throwaway-d
Copy link
Author

throwaway-d commented Apr 4, 2023

@github-actions I don’t like you. >:(

@Geeyun-JY3
Copy link
Collaborator

Geeyun-JY3 commented Apr 4, 2023

The reason why the read-only strings of F-Droid are blue is this project enables review.
Both approved strings and read-only strings are blue currently while enabling review.
Example: https://hosted.weblate.org/projects/f-droid/f-droid/zh_Hans/
image


@nijel Now that read-only is a state different from approved, I would suggest using a different color to indicate this state, such as black, blown, or something else.

@throwaway-d
Copy link
Author

Now that read-only is a state different from approved, I would suggest using a different color to indicate this state, such as black, blown, or something else.

Thank you a lot for the information! I agree with you! :D
We also need to make sure that the colors are differentiable for colorblind peope.

@nijel nijel added enhancement Adding or requesting a new feature. undecided These features might not be implemented. Can be prioritized by sponsorship. and removed wontfix Nobody will work on this. labels Apr 4, 2023
@nijel nijel reopened this Apr 4, 2023
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

This issue has been put aside. It is currently unclear if it will ever be implemented as it seems to cover too narrow of a use case or doesn't seem to fit into Weblate.

Please try to clarify the use case or consider proposing something more generic to make it useful to more users.

@nijel
Copy link
Member

nijel commented Apr 4, 2023

Blue is currently used for approved, so that's not an option. Choosing a different color that works for colorblind might be tricky…

@throwaway-d
Copy link
Author

throwaway-d commented Apr 4, 2023

a different color that works for colorblind

Actually, the current red/green are the worst colors for colorblind people.

@throwaway-d
Copy link
Author

I think gray might work.

@throwaway-d
Copy link
Author

When something on the interface is unclickable, UI designers often make that thing gray. When we see gray strings, we can easily learn that those strings are uneditable.

@throwaway-d
Copy link
Author

About accessibility, we should have many different color schemes for users to choose and users should be able to customize their own themes. This should be discussed on a different, separate issue.

This issue should be focused only on adding a new color for the default theme.

Funny thing is that Weblate still yet doesn’t have a default dark theme.

@Geeyun-JY3
Copy link
Collaborator

Dark mode is another long story: #2969

@nijel
Copy link
Member

nijel commented Apr 4, 2023

Yes, funny thing is that nobody contributed working dark theme so far.

@comradekingu
Copy link
Contributor

As an aside, blue already doesn't work for the colour-blind if there is no green in the middle(?)

"All strings" is gray, so black?

@throwaway-d
Copy link
Author

As an aside, blue already doesn't work for the colour-blind if there is no green in the middle(?)

If you mean to replace the color of translated strings from green to blue. It does work. See https://www.color-blindness.com/coblis-color-blindness-simulator/

1. Normal
colorblindtest

2. Red-Weak/Protanomaly
image

3. Green-Weak/Deuteranomaly
image

4. Blue-Weak/Tritanomaly
image

5. Red-Blind/Protanopia
image

6. Green-Blind/Deuteranopia
image

7. Blue-Blind/Tritanopia
image

8. Monochromacy/Achromatopsia
image

9. Blue Cone Monochromacy
image

@nijel nijel added the wontfix Nobody will work on this. label Apr 23, 2024
@nijel
Copy link
Member

nijel commented Apr 23, 2024

After a lot of discussion, we settled on a simplified color scheme in #9794. The progress bar indicates strings which do not need any action, and including read-only in that pack makes perfect sense.

@nijel nijel closed this as not planned Won't fix, can't repro, duplicate, stale Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature. undecided These features might not be implemented. Can be prioritized by sponsorship. wontfix Nobody will work on this.
Projects
None yet
Development

No branches or pull requests

4 participants