New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add night theme #2969
Comments
+1 |
Not yet, nobody contributed it so far. |
@Kyuuu If you aren't using custom CSS, or a plugin to do it. Isn't just the next website going to look too bright? |
Just want to note the existence of the
When/if this gets implemented, it would be nice if Weblate can default to the system theme if not explicitly set in Weblate itself. |
Would love to see this. So my users don't have to have bleeding eyes, nor stop being the night owls they are.. |
Hi everyone 👋, I just generated a dark mode CSS stylesheet for weblate using the Dark Reader browser extension. I haven't dealt with weblate's source code so far. So unfortunately I have no knowledge considering the JavaScript used. But generally speaking I'd solve the integration of the light/dark mode switch using either a server-side variable stored with the user's profile information or client-side using preferable local storage or cookies. Please see the attached CSS file. Please note that the file extension is 📎DarkReader-weblate-dark-mode.css Regards, Jean-Luc |
The generation of high contrast or sepia colored themes using the Dark Reader browser extension would be possible as well. So this might improve the accessibility of weblate in general. |
I would be very grateful if @nijel could look into this any time soon. Btw just wanted to express my gratitude for maintaining weblate. It's a awesome piece of software. |
Switching to SVG/Font based icons instead of images is fairly simple and there's also a way to invert the colors of an image with CSS. Regarding inverting colors: Regarding SVG/Fonts (There are many open source projects such as Feather, etc.), there are some equivalent icons: The simplest approach is to create root element in CSS for the dark/light mode and switch when necessary. I created an example here: Thanks :) |
I haven't checked the code, but I would assume those icons are SVGs. Should be an easy fix for the icons, and is not a hack. (This is how things like FontAwesome achieve setting the color of their icons through CSS.) |
Yes, using fill is probably the way to go. We already use that for coloring SVGs (and all icons are SVGs). It was just a statement that CSS in #2969 (comment) does not cover this. |
Any update on this? That white mode is killing me :/ |
This is needed for coloring them in #2969
- add CSS override for dark theme - add javascript to toggle that - TODO: add user configuration with peristence (probably using local storage or cookies to make this device specific) Fixes WeblateOrg#2969
Draft PR for this is available at #9361 What is missing is user configuration, and I'm hesitating here whether to make it in user settings and for all devices, or store it in the browser and have it per device. |
Thank you for working on this issue! |
IMHO this should not be stored anywhere but be left to the browser preference setting. |
The browser preference works already in the PR. Most sites allow you to configure this as well. Or is it no longer useful these days? |
- add CSS override for dark theme - add javascript to toggle that - TODO: add user configuration with peristence (probably using local storage or cookies to make this device specific) Fixes WeblateOrg#2969
- add CSS override for dark theme - add javascript to toggle that - allow to override this in the profile Fixes WeblateOrg#2969
- add CSS override for dark theme - add javascript to toggle that - allow to override this in the profile Fixes WeblateOrg#2969
- add CSS override for dark theme - add javascript to toggle that - allow to override this in the profile Fixes WeblateOrg#2969
* css: Add dark theme - add CSS override for dark theme - add javascript to toggle that - allow to override this in the profile Fixes #2969 * rephrasing docs --------- Co-authored-by: Benjamin Alan Jamie <benjamin@weblate.org>
Is your feature request related to a problem? Please describe.
I like to work at night. It would be nice to give my eyes some rest and be able to switch between day and night mode at any time.
Describe the solution you'd like
Possibility to switch between these modes.
Describe alternatives you've considered
//
Additional context
//
The text was updated successfully, but these errors were encountered: