Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling xml-invalid for the project #9168

Closed
2 tasks done
tomkolp opened this issue Apr 26, 2023 · 10 comments
Closed
2 tasks done

Disabling xml-invalid for the project #9168

tomkolp opened this issue Apr 26, 2023 · 10 comments
Assignees
Labels
bug Something is broken.
Milestone

Comments

@tomkolp
Copy link
Contributor

tomkolp commented Apr 26, 2023

Describe the issue

How to disable xml-invalid quality checks for an entire project in docker. It was recently automatically added to the entire project. How can you do it the fastest? The whole operation will probably take several days.

I've been reading the documentation but only found information about QA exclusions that apply to a standard weblate installation, not in containers.

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

1 Go to string translation
2 See new quality checks, completely redundant throughout the project

Expected behavior

No response

Screenshots

image

Exception traceback

No response

How do you run Weblate?

Docker container

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response

@tomkolp tomkolp added the question This is more a question for the support than an issue. label Apr 26, 2023
@github-actions
Copy link

This issue looks more like a support question than an issue. We strive to answer these reasonably fast, but purchasing the support subscription is not only more responsible and faster for your business but also makes Weblate stronger.

In case your question is already answered, making a donation is the right way to say thank you!

@nijel
Copy link
Member

nijel commented Apr 26, 2023

@tomkolp
Copy link
Contributor Author

tomkolp commented Apr 26, 2023

Add ignore-xml-invalid to component flags. See https://docs.weblate.org/en/latest/user/checks.html#xml-syntax and https://docs.weblate.org/en/latest/admin/projects.html#translation-flags

I know about the flag, but how do I add it to 3000 components at once?

I added a flag in the base file and it will be added automatically in newly created components. I know I can add it to the component as well, but I'd have to do it over 3000 times.

EDIT:
Might use WEBLATE_REMOVE_CHECK in docker compose, but what is the name of the variable for xml-invalid?

@nijel
Copy link
Member

nijel commented Apr 26, 2023

Use class name in WEBLATE_REMOVE_CHECK, those are documented in https://docs.weblate.org/en/latest/user/checks.html#xml-syntax

Maybe there is a bug in the check that it started to trigger now? It's not a new check.

@tomkolp
Copy link
Contributor Author

tomkolp commented Apr 26, 2023

image
We've always used <<player{text/text}>> , this check came out a few weeks ago for the first time.

@tomkolp
Copy link
Contributor Author

tomkolp commented Apr 26, 2023

I added to docker-compose:
WEBLATE_REMOVE_CHECK: weblate.checks.markup.XMLValidityCheck
I restarted the containers. The name of this check in the list of all changed its name from Polish to English. When I click on xml-invalid I get the page not found message. The following component have a check only now in English. Do I still need to force the rechecking somehow or is this some kind of bug? If I have to force it, how can I do it for all components?

image

image

image

@nijel
Copy link
Member

nijel commented Apr 28, 2023

You can force updating checks manually using https://docs.weblate.org/en/latest/admin/management.html#updatechecks, without that, the checks are updated once in a month (see https://docs.weblate.org/en/latest/admin/config.html#background-tasks).

@tomkolp
Copy link
Contributor Author

tomkolp commented Apr 28, 2023

I just wasn't sure if this behavior (message page cannot be displayed) is normal behavior after excluding checks.
I have enabled check recalculation for all components. Initially, I see that "xml-invalid" is disappearing. Seeing the speed of the operation, it will be completed in a few days.

Thanks for leading me to a solution.

@tomkolp tomkolp closed this as completed Apr 28, 2023
@github-actions
Copy link

The issue you have reported is now resolved. If you don’t feel it’s right, please follow its labels to get a clue for further steps.

  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

@nijel nijel added bug Something is broken. and removed question This is more a question for the support than an issue. labels May 18, 2023
@nijel nijel added this to the 4.18 milestone May 18, 2023
@nijel nijel self-assigned this May 18, 2023
nijel added a commit that referenced this issue May 18, 2023
Skip strings that contain no XML markup in the source string.

Fixes #9168
@nijel
Copy link
Member

nijel commented May 18, 2023

This turned out to be a bug in the XML check, I've just fixed that in 32220fc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

No branches or pull requests

2 participants