UI: Rename maintaince "Push" button based on project/component settings

[buhtz]

Describe the issue

In the maintaince section there is a button labeld "Push". This doesn't make sense when the component is setup to do PullRequests to the upstream repo.

I already tried

• I've read and searched the documentation.
• I've searched for similar issues in this repository.

Steps to reproduce the behavior

Setup "PullRequest" and look into maintaince section.

Expected behavior

Name the button "Push" when the component is setup with push behavior.
Name it "Create PullRequest" when PR behavior is setup.

Or just name it "Sync with upstream repo" in all cases.

Screenshots

Exception traceback

No response

How do you run Weblate?

Other

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response

[buhtz]

#8535

[nijel]

Well, it does both push (to a fork/branch) and create a pull/merge request in that case. But it makes sense to have a more verbose text here (I've already rewritten some of that page in 9c8dfd0).

[buhtz]

Well, it does both push (to a fork/branch) and create a pull/merge request in that case.

From a UI designers perspective it doesn't matter what "it does" but what the "users understand what happens".
On a shell I can do git push. That is a "Push".
On a code hoster I can create a PullRequest (or MergeRequest on GitLab). That is a "PullRequest".
Two totally different things from a users perspective.

A good UI should reflect the users perspective and/or guide him gently around it there is a need to.

[nijel]

I'm not saying that the current look is good, but that it only describes part of the operation :-).

[github-actions]

Thank you for your report; the issue you have reported has just been fixed.

• In case you see a problem with the fix, please comment on this issue.
• In case you see a similar problem, please open a separate issue.
• If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

[nijel]

Revamped repository maintenance:

[buhtz]

What changed? I still see the "Push" button here.

[nijel]

There is a service specific description next to it, for Gitea it is defined here:

weblate/weblate/vcs/git.py

Line 1117 in 20f06c4

push_label = gettext_lazy("This will push changes and create Gitea pull request.")

The button is still called "Push" as I don't see a better short naming here. Suggestions are welcome.