Broken link to privacy policy when accepting new terms of service

[yvanzo]

Describe the issue

When logging into a Weblate instance where the legal terms have been changed, the user is appropriately redirected to the form /legal/confirm/ which includes the new Terms of Service in a pre-scrollable div.

In this context, the (new) link to the privacy policy from the section 5 of the ToS is not working: It resolves to None. It seems that the template {{ privacy_url }} doesn’t resolve correctly in this context.

In other contexts, this link works fine:

• From /legal/terms/, it resolves to /legal/privacy/.
• From the all-in-one /en/terms/, it resolves to #privacy.

Template for the link: https://github.com/WeblateOrg/wllegal/blob/2023.3/wllegal/templates/legal/documents/tos.html#LL101C211-L101C235

I’m reporting this bug to wllegal as it occurs since its latest version 2023.3.
However I don’t know if it has to be addressed in wllegal and/or weblate.
I’ve searched for similar issues in both repositories.

I already tried

• I've read and searched the documentation.
• I've searched for similar issues in this repository.

Steps to reproduce the behavior

1. Go to /legal/confirm/?… (with an account having accepted old legal terms only, or using a new account?)
2. Scroll to the section 5 about personal data
3. Click on the link to the privacy policy
4. Get page not found from /legal/confirm/None

Expected behavior

4. Get /legal/privacy/, possibly in a new tab.

Screenshots

No response

Exception traceback

No response

Additional context

No response

[nijel]

Fixed in 45ddcee

[github-actions]

Thank you for your report; the issue you have reported has just been fixed.

• In case you see a problem with the fix, please comment on this issue.
• In case you see a similar problem, please open a separate issue.
• If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.