Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "Start new translation" button to the top #9441

Closed
buhtz opened this issue Jun 20, 2023 · 9 comments
Closed

Move "Start new translation" button to the top #9441

buhtz opened this issue Jun 20, 2023 · 9 comments
Assignees
Labels
enhancement Adding or requesting a new feature. ux Issues related to user experience.
Milestone

Comments

@buhtz
Copy link

buhtz commented Jun 20, 2023

Describe the problem

Some projects do have a long list of languages.

The button "Start new translations" at the end of that list disappear somehow because of that. The problem is that the users don't understand and know that they are able themselves to add new languages.

Describe the solution you'd like

Just move that button to the top of that list.

Describe alternatives you've considered

No response

Screenshots

No response

Additional context

No response

@nijel
Copy link
Member

nijel commented Jun 20, 2023

User languages are shown as one-click items on top of the list, so it is straightforward to add languages the user translates to:

image

@buhtz
Copy link
Author

buhtz commented Jun 21, 2023

Thanks for your reply. I've never saw something like this.

Not sure what I see there. It seems that it is an admin-view where the admin can decide to add a language some user has created and worked on?

That is not the step I'm talking about. I mean the user. The user want to add a new langauge. The button for this is at the end of the list.

image

@comradekingu
Copy link
Contributor

comradekingu commented Jun 26, 2023

Move to the top and don't leave the page to do it?

There is no telling whether it will be sort of close to the top, or far down.
New users will sometimes not find it, and old users will have to auto-scroll needlessly otherwise.

Ideally it would show as the top line as one of the added or languages that could be added, as that is already a working
theme/function.

bilde

Also moved the icons to the left of the language name, so they always align.
Also added different colour to missing strings, to make them distinct from untranslated ones.

I think just an outlined box for untranslated, and gray for not added is better to make that distinction though.
(Prevents green/red colour blindness problems.)

@buhtz
Copy link
Author

buhtz commented Jun 26, 2023

Thanks for this mockup.
Do I get it right that the first entry "Other language (with dropdown)" is the replacement for the "Start new translation" button?

As a user I wouldn't understand that this entry would result in a new language. It isn't only the string "Other language" it is also the following columns do have numbers in. Conceptually you do mix in that list existing and non existing things. That is not an elegant choice I would say.

I don't see the problem to move that button just to the top of the list. Isn't this the easiest?

@nijel nijel added ux Issues related to user experience. enhancement Adding or requesting a new feature. labels Jun 29, 2023
@nijel nijel added this to the 5.0 milestone Jun 29, 2023
@nijel nijel self-assigned this Jun 29, 2023
@nijel nijel closed this as completed in 38d1b98 Jun 29, 2023
@nijel
Copy link
Member

nijel commented Jun 29, 2023

I don't see a reason to move a rarely used button to a prominent place. Users will have configured their languages and those are shown on top. So, these can easily add their language already.

Such change would focus on admins, and those already have other add buttons at the bottom of the list (for example adding new component).

On the other side, I think it makes sense to add this to the top + dropdown.

@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

@buhtz
Copy link
Author

buhtz commented Jun 29, 2023

I don't see a reason to move a rarely used button to a prominent place. Users will have configured their languages and those are shown on top. So, these can easily add their language already.

Such change would focus on admins, and those already have other add buttons at the bottom of the list (for example adding new component).

On the other side, I think it makes sense to add this to the top + dropdown.

I assume we do misunderstand each other.
You say in the beginning "I don't see a reason to move..." and in the end the opposite "...I think it makes sense to add this to the top". And which "dropdown" do you mean? We never talked about a dropdown.

@comradekingu
Copy link
Contributor

comradekingu commented Jul 3, 2023

@buhtz He sees no reason to make it prominent, if functional and logically placed at that.
Instead removing it(?) and putting it behind the "+" button in a dropdown is a good balance, considering various usecases.

nijel added a commit that referenced this issue Jul 5, 2023
- add plus icon to the object listing
- the button is only shown on the empty list to make the add action more
  obvious
- all logic is now shared for language/project/component views

Fixes #9441
@nijel
Copy link
Member

nijel commented Jul 5, 2023

I've rearranged the UI for adding in dcdd417. There is now a plus icon in the list header to add a new language/component/translation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature. ux Issues related to user experience.
Projects
None yet
Development

No branches or pull requests

3 participants