Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Personal API key per default #9520

Closed
derkoe opened this issue Jul 7, 2023 · 3 comments
Closed

Hide Personal API key per default #9520

derkoe opened this issue Jul 7, 2023 · 3 comments
Assignees
@nijel
Labels
enhancement Adding or requesting a new feature. ux Issues related to user experience.
Milestone
5.0

Comments

@derkoe
Copy link
Contributor

derkoe commented Jul 7, 2023

Describe the problem

When you go to https://hosted.weblate.org/access/{project}/#api while screen sharing everybody will see you personal API key.

The same is true for https://hosted.weblate.org/accounts/profile/#api but I guess this does not happen that much.

Describe the solution you'd like

Hide the API key per default and only display it on some interaction ("Reveal key").

Describe alternatives you've considered

No response

Screenshots

No response

Additional context

No response
derkoe added a commit to derkoe/weblate that referenced this issue Jul 7, 2023
@derkoe
feat: hide personal API key on page display
f503aae 
The API key can be shown by clicking on a button. The already
implemented feature "Copy to clipboard" stays the same.

Closes WeblateOrg#9520
@derkoe
Copy link
Contributor Author

derkoe commented Jul 7, 2023

This would be a simple implementation for that: main...derkoe:feat/hide-api-key. Should I create a PR for that?

@nijel
Copy link
Member

nijel commented Jul 8, 2023

Yes, pull requests are welcome.

@nijel nijel added enhancement Adding or requesting a new feature. ux Issues related to user experience. labels Jul 8, 2023
@derkoe derkoe mentioned this issue Jul 8, 2023
Closed
5 tasks
@nijel nijel added this to the 5.0 milestone Aug 1, 2023
@nijel nijel assigned nijel and unassigned derkoe Aug 1, 2023
@nijel nijel closed this as completed in 81af019 Aug 1, 2023
nijel added a commit that referenced this issue Aug 1, 2023
@nijel
ui: hide token on data page as well
c821091 
See #9520
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nijel nijel

Labels
enhancement Adding or requesting a new feature. ux Issues related to user experience.
Projects
None yet
Milestone
5.0
Development

Successfully merging a pull request may close this issue.

feat: hide personal API key on page display derkoe/weblate
2 participants
@derkoe @nijel