Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: Factor out word counting #10279

Merged
merged 1 commit into from
Oct 26, 2023
Merged

utils: Factor out word counting #10279

merged 1 commit into from
Oct 26, 2023

Conversation

nijel
Copy link
Member

@nijel nijel commented Oct 26, 2023

Proposed changes

This makes both location use consistent implementation.

See #10278

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

This makes both location use consistent implementation.

See WeblateOrg#10278
@nijel nijel added this to the 5.2 milestone Oct 26, 2023
@nijel nijel self-assigned this Oct 26, 2023
@nijel nijel enabled auto-merge (rebase) October 26, 2023 18:30
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #10279 (8685699) into main (d8e6e11) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #10279   +/-   ##
=======================================
  Coverage   90.86%   90.86%           
=======================================
  Files         544      544           
  Lines       55862    55864    +2     
  Branches     8859     8859           
=======================================
+ Hits        50757    50760    +3     
  Misses       3548     3548           
+ Partials     1557     1556    -1     
Files Coverage Δ
weblate/trans/models/unit.py 86.09% <100.00%> (ø)
weblate/trans/util.py 86.16% <100.00%> (+0.17%) ⬆️
weblate/trans/views/reports.py 93.19% <100.00%> (ø)

... and 1 file with indirect coverage changes

@nijel nijel merged commit 8e70c2f into WeblateOrg:main Oct 26, 2023
29 of 30 checks passed
@nijel nijel deleted the count-words branch October 26, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant