feat(machinery): allow base_url of OpenAI to be customized #11467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows usage of local LLMs or other providers
|
Can you please add documentation which other providers or local LLM work with the OpenAI API and how to configure these? |
nijel
reviewed
Apr 23, 2024
Co-authored-by: Michal Čihař <michal@cihar.com>
for more information, see https://pre-commit.ci
nijel
reviewed
Apr 23, 2024
| widget=forms.Textarea, | ||
| help_text=gettext_lazy("Base URL of the OpenAI API"), | ||
| required=False, | ||
| default=None, |
There was a problem hiding this comment.
TypeError: Field.init() got an unexpected keyword argument 'default'
See https://github.com/WeblateOrg/weblate/actions/runs/8800026958/job/24150336022?pr=11467
Seriously, has this been tested?
There was a problem hiding this comment.
@nijel No, I just pushed it to see the pipeline! Not ready for review! I should have marked it as a draft!
Thanks for the fast review though.
There was a problem hiding this comment.
I recommend testing locally first against real custom API endpoint. The model selection will need to be changed for custom LLMs as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows usage of local LLMs or other providers
Proposed changes
Adds a new field when setting up the OpenAI integration to allow the user to add a custom base_url
Checklist
Other information