Fix 'Rescan' not enforcing rescan of source translation files. #11687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the `force` option to `True` when calling `create_translations` in the `do_file_scan` handler, as already done by the `do_reset` one. Currently, 'Reset' will (after resetting the weblate repository), enforce a complete rescan of all source translation files (e.g. all PO files). The 'Rescan' option however, does not. As a consequence, translations sources are only re-scanned in case the source files are actually detected as changed since last update. This behavior does not seem consistent with the description of this command (`Loads translations from the files into Weblate. Use when Weblate missed some of the strings after updating the repository`). And it does not indeed actually update translations when e.g. the regular 'Update' command failed to finish properly (due to reaching the request timeout delay of the WSGI server e.g.).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11687 +/- ##
==========================================
- Coverage 90.82% 90.52% -0.30%
==========================================
Files 554 572 +18
Lines 57306 58664 +1358
Branches 9122 9371 +249
==========================================
+ Hits 52046 53104 +1058
- Misses 3640 3853 +213
- Partials 1620 1707 +87
|
|
Merged, thanks for your contribution! |
|
Thanks for the fast handling! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Set the
forceoption toTruewhen callingcreate_translationsin thedo_file_scanhandler, as already done by thedo_resetone.Currently, 'Reset' will (after resetting the weblate repository) enforce a complete rescan of all source translation files (e.g. all PO files).
The 'Rescan' option however, does not. As a consequence, translations sources are only re-scanned in case the source files are actually detected as changed since last update.
This behavior does not seem consistent with the description of this command (
Loads translations from the files into Weblate. Use when Weblate missed some of the strings after updating the repository).And it does not indeed actually update translations when e.g. the regular 'Update' command failed to finish properly (due to reaching the request timeout delay of the WSGI server e.g.).
Checklist
Other information
Found out this unexpected behavior while investigating 'missed updates' issues for some of our translations at translate.blender.org