feat(Notifications): Added translation notifications #11712

JoaoCodificacoes · 2024-05-25T13:01:01Z

Proposed changes

Added a new notification for:

when all the languages in component are translated.
when a language is translated.

Addresses: #4294 and #11215

Checklist

[x ] Lint and unit tests pass locally with my changes.
[x ] I have added tests that prove my fix is effective or that my feature works.
I have added documentation to describe my feature.
[x ] I have squashed my commits into logic units.
[x ] I have described the changes in the commit messages.

JoaoCodificacoes · 2024-06-03T14:40:56Z

Hey, is there something else that needs to be done?

Added a new notification for: - when all the languages in component are translated. - when a language is translated. Addresses: WeblateOrg#4294 and WeblateOrg#11215 Co-authored-by: Manuel Cruz <manuelmcruz@tecnico.ulisboa.pt>

for more information, see https://pre-commit.ci

weblate/trans/tasks.py

weblate/accounts/notifications.py

weblate/accounts/tests/test_notifications.py

weblate/templates/mail/translated_language.html

weblate/trans/tasks.py

weblate/accounts/tests/test_notifications.py

Co-authored-by: Manuel Cruz <manuelmcruz@tecnico.ulisboa.pt>

…me scope as global Co-authored-by: Manuel Cruz <manuelmcruz@tecnico.ulisboa.pt>

…onent Co-authored-by: Manuel Cruz <manuelmcruz@tecnico.ulisboa.pt>

…caton Co-authored-by: Manuel Cruz <manuelmcruz@tecnico.ulisboa.pt>

nijel

Thanks, looks better now. There is also missing database migration, see https://github.com/WeblateOrg/weblate/actions/runs/9573747553/job/26395745226?pr=11712

weblate/accounts/tests/test_views.py

weblate/accounts/tests/test_notifications.py

nijel · 2024-06-19T07:28:47Z

@orangesunny Can you please review texts in the notifications?

orangesunny · 2024-06-19T08:03:40Z

sure

Co-authored-by: Manuel Cruz <manuelmcruz@tecnico.ulisboa.pt>

JoaoCodificacoes · 2024-06-19T13:59:39Z

Thanks, looks better now. There is also missing database migration, see https://github.com/WeblateOrg/weblate/actions/runs/9573747553/job/26395745226?pr=11712

Thanks for the help, we were wondering if we could get some help with the migrations, do they also need to be added in accounts/data.py ?

nijel · 2024-06-19T14:50:13Z

Avoid manual changes in the migration files and just run ./manage.py makemigrations. That will create the two needed migrations. See https://docs.djangoproject.com/en/5.0/topics/migrations/ for more info on the topic.

codecov · 2024-06-19T16:09:58Z

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.61%. Comparing base (6aee586) to head (24dcbae).
Report is 2285 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11712      +/-   ##
==========================================
- Coverage   90.82%   90.61%   -0.21%     
==========================================
  Files         554      579      +25     
  Lines       57306    58854    +1548     
  Branches     9122     9396     +274     
==========================================
+ Hits        52046    53329    +1283     
- Misses       3640     3832     +192     
- Partials     1620     1693      +73

Files	Coverage Δ
...migrations/0011_alter_subscription_notification.py	`100.00% <100.00%> (ø)`
weblate/accounts/notifications.py	`95.85% <100.00%> (+0.13%)`	⬆️
weblate/accounts/tests/test_notifications.py	`100.00% <100.00%> (ø)`
weblate/accounts/tests/test_views.py	`100.00% <ø> (ø)`
...blate/trans/migrations/0019_alter_change_action.py	`100.00% <100.00%> (ø)`
weblate/trans/models/change.py	`82.26% <100.00%> (+3.25%)`	⬆️
weblate/trans/tasks.py	`69.23% <33.33%> (-3.11%)`	⬇️

... and 325 files with indirect coverage changes

Co-authored-by: Manuel Cruz <manuelmcruz@tecnico.ulisboa.pt>

…translation_notifications

This reverts commit 5602981.

This reverts commit 85bcd52.

JoaoCodificacoes · 2024-06-19T16:15:34Z

Avoid manual changes in the migration files and just run ./manage.py makemigrations. That will create the two needed migrations. See https://docs.djangoproject.com/en/5.0/topics/migrations/ for more info on the topic.

Alright, thanks for the help.

weblate/templates/mail/translated_component.html

weblate/templates/mail/translated_language.html

orangesunny

Subjects of the notifications are fine

weblate/accounts/tests/test_notifications.py

weblate/trans/tasks.py

weblate/trans/models/change.py

weblate/trans/migrations/0019_alter_change_action.py

for more information, see https://pre-commit.ci

weblate/accounts/tests/test_notifications.py

JoaoCodificacoes force-pushed the translation_notifications branch from 523e4d5 to 9a6b557 Compare June 4, 2024 00:19

feat(Notifications): Added translation notifications

dc8bc0f

Added a new notification for: - when all the languages in component are translated. - when a language is translated. Addresses: WeblateOrg#4294 and WeblateOrg#11215 Co-authored-by: Manuel Cruz <manuelmcruz@tecnico.ulisboa.pt>

JoaoCodificacoes force-pushed the translation_notifications branch from b58ed6d to dc8bc0f Compare June 5, 2024 20:14

JoaoCodificacoes and others added 2 commits June 5, 2024 21:16

Merge branch 'main' into translation_notifications

bfcd162

[pre-commit.ci] auto fixes from pre-commit.com hooks

531df79

for more information, see https://pre-commit.ci

nijel reviewed Jun 18, 2024

View reviewed changes

nijel added this to the 5.7 milestone Jun 18, 2024

nijel reviewed Jun 18, 2024

View reviewed changes

weblate/accounts/tests/test_notifications.py Show resolved Hide resolved

JoaoCodificacoes and others added 6 commits June 18, 2024 23:42

Merge branch 'WeblateOrg:main' into translation_notifications

b682758

fix(template): applied changes in translated_language template

e2e003f

Co-authored-by: Manuel Cruz <manuelmcruz@tecnico.ulisboa.pt>

fix(testsuite): updated notification subscription count

579ba17

Co-authored-by: Manuel Cruz <manuelmcruz@tecnico.ulisboa.pt>

fix(test_notifications): Updated notify_language_translated to use sa…

2d4ede0

…me scope as global Co-authored-by: Manuel Cruz <manuelmcruz@tecnico.ulisboa.pt>

fix(tasks): refactored code and reverted relocation of change to comp…

d15015b

…onent Co-authored-by: Manuel Cruz <manuelmcruz@tecnico.ulisboa.pt>

fix(notifications): removed get_context from LanguageTranslatedNotifi…

d8a9c66

…caton Co-authored-by: Manuel Cruz <manuelmcruz@tecnico.ulisboa.pt>

nijel reviewed Jun 19, 2024

View reviewed changes

weblate/accounts/tests/test_views.py Show resolved Hide resolved

weblate/accounts/tests/test_notifications.py Outdated Show resolved Hide resolved

weblate/accounts/tests/test_notifications.py Outdated Show resolved Hide resolved

nijel requested a review from orangesunny June 19, 2024 07:28

JoaoCodificacoes and others added 4 commits June 19, 2024 12:36

fix(testsuite): updated subscription set count in test_watch

eece745

Co-authored-by: Manuel Cruz <manuelmcruz@tecnico.ulisboa.pt>

fix(test_notifications): updated to use same scope as real code

e959243

Co-authored-by: Manuel Cruz <manuelmcruz@tecnico.ulisboa.pt>

fix(migrations): added database migration

85bcd52

Co-authored-by: Manuel Cruz <manuelmcruz@tecnico.ulisboa.pt>

fix(migrations): added database migration

5602981

Co-authored-by: Manuel Cruz <manuelmcruz@tecnico.ulisboa.pt>

JoaoCodificacoes and others added 4 commits June 19, 2024 17:13

fix(migrations): added database migration

3b80db0

Co-authored-by: Manuel Cruz <manuelmcruz@tecnico.ulisboa.pt>

Merge remote-tracking branch 'origin/translation_notifications' into …

4e17339

…translation_notifications

Revert "fix(migrations): added database migration"

cf6c4c7

This reverts commit 5602981.

Revert "fix(migrations): added database migration"

023504e

This reverts commit 85bcd52.

This was linked to issues Jun 24, 2024

Receive Notification When Component is Completely Translated #4294

Closed

Add 'translation completed' to the Notifications for Watched and Managed projects #11215

Closed

orangesunny added 2 commits June 24, 2024 14:50

added !

c3a03c9

added .

d3588fd

nijel reviewed Jun 24, 2024

View reviewed changes

weblate/templates/mail/translated_component.html Outdated Show resolved Hide resolved

weblate/templates/mail/translated_language.html Outdated Show resolved Hide resolved

orangesunny and others added 3 commits June 24, 2024 14:58

rephasing

f185d9b

Remove not needed templates

ed42a8d

rephrasing

7c51f7c

orangesunny approved these changes Jun 24, 2024

View reviewed changes

nijel reviewed Jun 24, 2024

View reviewed changes

weblate/accounts/tests/test_notifications.py Outdated Show resolved Hide resolved

weblate/accounts/tests/test_notifications.py Outdated Show resolved Hide resolved

nijel reviewed Jun 24, 2024

View reviewed changes

weblate/trans/tasks.py Outdated Show resolved Hide resolved

Fix tests

d34b38c

nijel reviewed Jun 24, 2024

View reviewed changes

weblate/trans/models/change.py Outdated Show resolved Hide resolved

nijel reviewed Jun 24, 2024

View reviewed changes

weblate/trans/migrations/0019_alter_change_action.py Outdated Show resolved Hide resolved

nijel and others added 2 commits June 24, 2024 15:06

Improved event name

767e806

[pre-commit.ci] auto fixes from pre-commit.com hooks

7d16f5d

for more information, see https://pre-commit.ci

nijel enabled auto-merge (squash) June 24, 2024 13:08

nijel reviewed Jun 24, 2024

View reviewed changes

weblate/accounts/tests/test_notifications.py Outdated Show resolved Hide resolved

Update weblate/accounts/tests/test_notifications.py

24dcbae

nijel merged commit 8462ccc into WeblateOrg:main Jun 24, 2024
31 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Notifications): Added translation notifications #11712

feat(Notifications): Added translation notifications #11712

JoaoCodificacoes commented May 25, 2024

JoaoCodificacoes commented Jun 3, 2024

nijel left a comment

nijel commented Jun 19, 2024

orangesunny commented Jun 19, 2024

JoaoCodificacoes commented Jun 19, 2024

nijel commented Jun 19, 2024

codecov bot commented Jun 19, 2024 •

edited

Loading

JoaoCodificacoes commented Jun 19, 2024

orangesunny left a comment

feat(Notifications): Added translation notifications #11712

feat(Notifications): Added translation notifications #11712

Conversation

JoaoCodificacoes commented May 25, 2024

Proposed changes

Checklist

JoaoCodificacoes commented Jun 3, 2024

nijel left a comment

Choose a reason for hiding this comment

nijel commented Jun 19, 2024

orangesunny commented Jun 19, 2024

JoaoCodificacoes commented Jun 19, 2024

nijel commented Jun 19, 2024

codecov bot commented Jun 19, 2024 • edited Loading

Codecov Report

JoaoCodificacoes commented Jun 19, 2024

orangesunny left a comment

Choose a reason for hiding this comment

codecov bot commented Jun 19, 2024 •

edited

Loading