Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formats): avoid using internal unit in add_unit() #11847

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

nijel
Copy link
Member

@nijel nijel commented Jun 13, 2024

Proposed changes

This breaks in multivalue storage and is using internals where not necessary.

Fixes WEBLATE-CH

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel nijel added this to the 5.6 milestone Jun 13, 2024
@nijel nijel self-assigned this Jun 13, 2024
@nijel nijel enabled auto-merge (rebase) June 13, 2024 09:56
@nijel nijel force-pushed the add-unit branch 2 times, most recently from a117283 to 5bae95e Compare June 13, 2024 17:39
This breaks in multivalue storage and is using internals where not
necessary.

Fixes WEBLATE-CH
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.57%. Comparing base (6aee586) to head (77b4f94).
Report is 2135 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11847      +/-   ##
==========================================
- Coverage   90.82%   90.57%   -0.25%     
==========================================
  Files         554      576      +22     
  Lines       57306    58707    +1401     
  Branches     9122     9386     +264     
==========================================
+ Hits        52046    53173    +1127     
- Misses       3640     3835     +195     
- Partials     1620     1699      +79     
Files Coverage Δ
weblate/formats/base.py 89.86% <100.00%> (+0.08%) ⬆️
weblate/formats/tests/test_formats.py 99.76% <100.00%> (+<0.01%) ⬆️
weblate/formats/ttkit.py 90.84% <100.00%> (-0.57%) ⬇️
weblate/formats/txt.py 79.87% <100.00%> (-0.52%) ⬇️
weblate/trans/models/translation.py 86.71% <100.00%> (-0.50%) ⬇️
weblate/formats/convert.py 87.64% <50.00%> (-1.22%) ⬇️
weblate/formats/multi.py 83.62% <40.00%> (-3.88%) ⬇️

... and 316 files with indirect coverage changes

@nijel nijel merged commit 7b9d22d into WeblateOrg:main Jun 17, 2024
28 of 31 checks passed
@nijel nijel deleted the add-unit branch June 17, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant