-
-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve daterange selection for changes #11894
Improve daterange selection for changes #11894
Conversation
5940167
to
5687112
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11894 +/- ##
==========================================
- Coverage 90.82% 90.59% -0.23%
==========================================
Files 554 577 +23
Lines 57306 58827 +1521
Branches 9122 9392 +270
==========================================
+ Hits 52046 53297 +1251
- Misses 3640 3837 +197
- Partials 1620 1693 +73
|
weblate/trans/views/reports.py
Outdated
if form.cleaned_data["period"]: | ||
start_date = form.cleaned_data["period"]["start_date"] | ||
end_date = form.cleaned_data["period"]["end_date"] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the changes here as well, reports need period to be provided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted the changes for checking if the form.cleaned_data["period"]
is None.
5687112
to
faf1e28
Compare
This introduced regression: #11954 |
Proposed changes
This improves the selection of date ranges for the generation of changes using the
DateRangeField
.This solves issue #11846.
Example image:
![Screenshot 2024-06-19 at 15-40-35 Changes @ Devel Weblate](https://private-user-images.githubusercontent.com/20557045/340975474-92a06886-eefd-475d-ae91-88065f2d305e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk4NTAzOTAsIm5iZiI6MTcxOTg1MDA5MCwicGF0aCI6Ii8yMDU1NzA0NS8zNDA5NzU0NzQtOTJhMDY4ODYtZWVmZC00NzVkLWFlOTEtODgwNjVmMmQzMDVlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzAxVDE2MDgxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE5NTgyZjgzYTVlMWE1NjQyYWE2MmRlYTUwYmYzM2Y1MDM0YWY4NGE3MWU1NWZmYzBmNDk4MmEwZmRjM2JkMWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.NO3woySCX4h64SzCMo8B0IIr7vJ1LlBCO23Ym5kLltg)
Checklist
Other information