Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace misaka with mistletoe #11905

Merged
merged 11 commits into from
Jun 25, 2024

Conversation

gersona
Copy link
Contributor

@gersona gersona commented Jun 20, 2024

fixes #9786

Proposed changes

Re-implement the markdown rendering module with the mistletoe library since mikasa is no longer maintained

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

I need help figuring out how to properly remove the dependency references to mikasa in the pyproject.toml and requirements.py files

Copy link
Member

@nijel nijel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove misaka from the requirements in pyproject.toml it should not be needed anymore.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.61%. Comparing base (6aee586) to head (765afda).
Report is 2307 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11905      +/-   ##
==========================================
- Coverage   90.82%   90.61%   -0.21%     
==========================================
  Files         554      581      +27     
  Lines       57306    58966    +1660     
  Branches     9122     9408     +286     
==========================================
+ Hits        52046    53434    +1388     
- Misses       3640     3836     +196     
- Partials     1620     1696      +76     
Files Coverage Δ
weblate/utils/tests/test_markdown.py 100.00% <100.00%> (ø)
weblate/utils/markdown.py 96.49% <94.44%> (-3.51%) ⬇️

... and 340 files with indirect coverage changes

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

weblate/utils/tests/test_markdown.py Show resolved Hide resolved
weblate/utils/tests/test_markdown.py Show resolved Hide resolved
weblate/utils/tests/test_markdown.py Show resolved Hide resolved
@nijel nijel added this to the 5.7 milestone Jun 21, 2024
weblate/utils/markdown.py Outdated Show resolved Hide resolved
@nijel nijel enabled auto-merge (squash) June 24, 2024 12:42
@nijel
Copy link
Member

nijel commented Jun 24, 2024

Scheduled for merge, thanks for your contribution!

@nijel nijel self-assigned this Jun 24, 2024
nijel added a commit that referenced this pull request Jun 25, 2024
It is already used for markdown format and will be used to render after
issue #9786 is fixed (see #11905).
@nijel nijel merged commit 4c22536 into WeblateOrg:main Jun 25, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace misaka with mistletoe
2 participants