-
-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace misaka with mistletoe #11905
Replace misaka with mistletoe #11905
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove misaka
from the requirements in pyproject.toml
it should not be needed anymore.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11905 +/- ##
==========================================
- Coverage 90.82% 90.61% -0.21%
==========================================
Files 554 581 +27
Lines 57306 58966 +1660
Branches 9122 9408 +286
==========================================
+ Hits 52046 53434 +1388
- Misses 3640 3836 +196
- Partials 1620 1696 +76
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
Scheduled for merge, thanks for your contribution! |
fixes #9786
Proposed changes
Re-implement the markdown rendering module with the mistletoe library since mikasa is no longer maintained
Checklist
Other information
I need help figuring out how to properly remove the dependency references to
mikasa
in thepyproject.toml
andrequirements.py
files