Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Upgrade Weblate language reworked #6332

Closed
wants to merge 5 commits into from

Conversation

comradekingu
Copy link
Contributor

@comradekingu comradekingu commented Jul 24, 2021

This became the topic of not wanting or daring to upgrade, and I think this will help a little bit.


Notable configuration or dependencies changes:

* There are some changes in quality checks, you might want to include them in case you modified the :setting:`CHECK_LIST`.
* The source language attribute was moved from project to a component what is exposed in the API. You will need to update :ref:`wlc` in case you are using it.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is?

docs/admin/upgrade.rst Outdated Show resolved Hide resolved

Notable configuration or dependencies changes:

* There are new file formats, you might want to include them in case you modified the :setting:`WEBLATE_FORMATS`.
* New file formats. You might want to include them in case you modified the :setting:`WEBLATE_FORMATS`.
* API for creating components now automatically uses :ref:`internal-urls`, see :http:post:`/api/projects/(string:project)/components/`.
* There is a change in dependencies and :setting:`django:PASSWORD_HASHERS` to prefer Argon2 for passwords hashing.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A dependency change of what? Now prefers? "password hashing"

on older version, please perform migration to Python 3 first on existing
version and upgrade later. See `Upgrading from Python 2 to Python 3 in the Weblate
Weblate no longer supports Python older than 3.5. If you are still running
on older version, please migrate to Python 3 first on an existing Weblate
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making 100% sure this shouldn't be "Python version"


.. code-block:: sh

weblate dumpdata --all --output weblate.json
weblate loaddata weblate.json --database=postgresql

4. Adjust :setting:`django:DATABASES` to use just PostgreSQL database as default,
4. Adjust :setting:`django:DATABASES` to only use the PostgreSQL database,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure there isn't a fallback database.

@@ -350,7 +350,7 @@ Migrating to PostgreSQL using pgloader

The `pgloader`_ is a generic migration tool to migrate data to PostgreSQL. You can use it to migrate Weblate database.

1. Adjust your :file:`settings.py` to use PostgreSQL as a database.
1. Adjust your :file:`settings.py` to use PostgreSQL as your database.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are multiple databases at once possible? Otherwise this is good.


.. versionchanged:: 4.4.1

* :ref:`mono_gettext` now uses both ``msgid`` and ``msgctxt`` when present. This will change identification of translation strings in such files breaking links to Weblate extended data such as screenshots or review states. Please make sure you commit pending changes in such files prior upgrading and it is recommeded to force loading of affected component using :djadmin:`loadpo`.
* Increased minimal required version of translate-toolkit to address several file format issues.
* :ref:`mono_gettext` now uses both ``msgid`` and ``msgctxt`` when present. This changes identification of translation strings in such files, breaking links to extended Weblate data such as screenshots or review states. Please ensure you commit pending changes in such files prior to upgrading. It is recommended to force-load affected components using :djadmin:`loadpo`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* :ref:`mono_gettext` now uses both ``msgid`` and ``msgctxt`` when present. This changes identification of translation strings in such files, breaking links to extended Weblate data such as screenshots or review states. Please ensure you commit pending changes in such files prior to upgrading. It is recommended to force-load affected components using :djadmin:`loadpo`.
* :ref:`mono_gettext` now uses both ``msgid`` and ``msgctxt`` when present. This changes identification of translation strings in such files, breaking links to extended Weblate data such as screenshots or review states. Please ensure you commit pending changes in such files prior to upgrading. It is recommended to force-load the affected component using :djadmin:`loadpo`.

?

@codecov
Copy link

codecov bot commented Jul 24, 2021

Codecov Report

Merging #6332 (04134ac) into main (aedd0a0) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 04134ac differs from pull request most recent head 2272510. Consider uploading reports for the commit 2272510 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6332   +/-   ##
=======================================
  Coverage   91.42%   91.43%           
=======================================
  Files         622      622           
  Lines       46772    46772           
  Branches     5161     5161           
=======================================
+ Hits        42762    42764    +2     
+ Misses       2715     2714    -1     
+ Partials     1295     1294    -1     
Impacted Files Coverage Δ
weblate/utils/checks.py 70.00% <0.00%> (+0.86%) ⬆️

@@ -1,45 +1,44 @@
Upgrading Weblate
=================

Docker image upgrades
Docker-image upgrades
Copy link
Member

@nijel nijel Aug 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Nobody seems to use it this way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To distinguish between "Upgrades of the docker image", and "Image upgrades labeled "Docker"".
https://www.grammarly.com/blog/hyphen/
Used elsewhere in Weblate after the debate where I was made aware.

@github-actions
Copy link

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

@github-actions github-actions bot added the wontfix Nobody will work on this. label Sep 19, 2021
@orangesunny orangesunny removed the wontfix Nobody will work on this. label Sep 19, 2021
@github-actions
Copy link

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

@github-actions github-actions bot added the wontfix Nobody will work on this. label Oct 20, 2021
@nijel nijel removed the wontfix Nobody will work on this. label Nov 3, 2021
comradekingu added a commit to comradekingu/Weblate that referenced this pull request Nov 13, 2021
@comradekingu
Copy link
Contributor Author

Somehow #6084 already existed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants