Set a default dispatch_list. #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ist. Detect undefined dispatch list in code, and use empty list by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dispatch_list variable used to be set to an empty list in webmachine.app. The following pull request (https://github.com/basho/webmachine/pull/32) removed the dispatch_list variable from webmachine.app, causing the default dispatch list to be undefined, causing problems in unit tests that assumed an empty--but defined--dispatch list.
This pull request causes webmachine to return an empty list rather than undefined if the dispatch list is undefined. My understanding, based on pull request https://github.com/basho/webmachine/pull/31 is that we can't specify a dispatch_list in webmachine.app because it affects hot upgrades.