Do not call onEnded when looping

It doesn't make sense, as the video doesn't technically "end" Closes cookpete/react-player#496
Webmaster1116 · Nov 17, 2018 · 1b9a233 · 1b9a233
1 parent 81c7dcd
commit 1b9a233
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -92,7 +92,7 @@ Prop | Description
 `onPause` | Called when media is paused
 `onBuffer` | Called when media starts buffering
 `onSeek` | Called when media seeks with `seconds` parameter
-`onEnded` | Called when media finishes playing
+`onEnded` | Called when media finishes playing<br />&nbsp; ◦ &nbsp;Does not fire when `loop` is set to `true`
 `onError` | Called when an error occurs whilst attempting to play media
 `onEnablePIP` | Called when picture-in-picture mode is enabled
 `onDisablePIP` | Called when picture-in-picture mode is disabled

diff --git a/src/Player.js b/src/Player.js
@@ -183,8 +183,8 @@ export default class Player extends Component {
     }
     if (!loop) {
       this.isPlaying = false
+      onEnded()
     }
-    onEnded()
   }
   onDurationCheck = () => {
     clearTimeout(this.durationCheckTimeout)