Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert back to the official Gluegun package #278

Open
mikenikles opened this issue Nov 11, 2022 · 2 comments
Open

Revert back to the official Gluegun package #278

mikenikles opened this issue Nov 11, 2022 · 2 comments

Comments

@mikenikles
Copy link
Collaborator

With the change in the plugin structure, we can possibly get rid of our custom gluegun implementation. Shall we do this in this PR, or in a follow-up?

In my opinion, this PR is big enough, so I'd say we should do it in a new one. In case you think we should do it with this, I'd be fine with it either. 👍

Originally posted by @Cahllagerfeld in #274 (comment)

@Cahllagerfeld
Copy link
Member

The only downside might be the failing CI again, because of the change that happened with node 14 and 16

@Cahllagerfeld
Copy link
Member

Conclusion on this. We may delete our fork, refork and just do that one single adjustment to remove that TS-Error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants