New Plugin-Structure #274
New Plugin-Structure #274
Conversation
🦋 Changeset detectedLatest commit: 6a208cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
A few nit picks and one outstanding question: Should we rename packages/create-webstone-app/template to templates and create a new app sibling directory next to plugin?
The app directory contains the README.md file. This way, we cleanly separate app from plugin and maybe other templates later.
packages/create-webstone-app/template/plugin/structure/packages/cli/package.json
Outdated
Show resolved
Hide resolved
packages/create-webstone-app/src/tasks/2-setup-project/application.ts
Outdated
Show resolved
Hide resolved
packages/create-webstone-app/src/tasks/2-setup-project/plugin.ts
Outdated
Show resolved
Hide resolved
packages/create-webstone-app/src/tasks/2-setup-project/plugin.ts
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "useTabs": true, | |||
| "singleQuote": true, | |||
There was a problem hiding this comment.
Are you sure about that? We use double quotes in our code.
packages/create-webstone-app/template/plugin/structure/package.json
Outdated
Show resolved
Hide resolved
packages/create-webstone-app/template/plugin/structure/package.json
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "useTabs": true, | |||
| "singleQuote": true, | |||
There was a problem hiding this comment.
Same as above, is this intended?
There was a problem hiding this comment.
If I'm not wrong I copied the one that gets delivered when crating a new sveltekit app that has prettier configured 🤔
There was a problem hiding this comment.
👍 If that's the case, let's keep it so cli and web plugins have consistent formatting.
packages/create-webstone-app/template/plugin/structure/packages/cli/package.json
Outdated
Show resolved
Hide resolved
packages/create-webstone-app/templates/plugin/structure/README.md
Outdated
Show resolved
Hide resolved
|
With the change in the plugin structure, we can possibly get rid of our custom gluegun implementation. Shall we do this in this PR, or in a follow-up? In my opinion, this PR is big enough, so I'd say we should do it in a new one. In case you think we should do it with this, I'd be fine with it either. 👍 |
closes #273
commandsandextensionsWe'll need some documentation around that, especially the changeset thing, as the action will fail without a proper setup. @mikenikles Do you think we should adjust the Readme, or keep the docs somewhere else for now?