Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【微信小程序】支持小程序Short Link #2306

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

linlinjava
Copy link

No description provided.

@binarywang
Copy link
Member

感觉完全没必要新建一个service类来增加单独的一个接口,你完全可以在WxMaLinkService这个上面增加方法

@linlinjava
Copy link
Author

你可以看一下微信小程序文档,Url Scheme、Url Link和Short Link 是独立的文档,因此代码实现结构也建议独立。

@binarywang
Copy link
Member

binarywang commented Sep 10, 2021

你可以看一下微信小程序文档,Url Scheme、Url Link和Short Link 是独立的文档,因此代码实现结构也建议独立。

文档独立可以理解。但是这两个都是link相关的,放到以link命名的service里更符合常理

@binarywang
Copy link
Member

代码先合并了,后期在进行重构

@binarywang binarywang merged commit ea31b7b into Wechat-Group:develop Sep 10, 2021
@binarywang binarywang added this to the 4.1.9 milestone Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants