Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【微信OCR】WxOcrIdCardResult 补全字段: addr、gender、nationality #2745

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

luomin0601
Copy link

WxOcrIdCardResult add field:

addr、gender、nationality

原测试用例:

cn.binarywang.wx.miniapp.api.impl.WxMaOcrServiceImplTest#testIdCard

@@ -22,6 +22,12 @@ public class WxOcrIdCardResult implements Serializable {
private String name;
@SerializedName("id")
private String id;
@SerializedName("addr")
private String addr;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SameNameButDifferent: The name addr; refers to [java.lang.SuppressWarnings, java.lang.String] within this file. It may be confusing to have the same name refer to multiple types. Consider qualifying them for clarity.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@binarywang binarywang added this to the 4.3.8 milestone Jul 14, 2022
@binarywang binarywang merged commit 6cbfe0a into Wechat-Group:develop Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants