增加小程序码支持，修正推送模板错误属性引发的NullPoint，增加TestCase #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
修复小程序模板推送读取错误字段导致的NullPoint
修复小程序模板推送读取错误字段导致的NullPoint
binarywang
reviewed
Jul 27, 2017
| * lineColor 包装类 | ||
| * 用于描述二维码（小程序码）颜色（RGB参数值），详情请查看文档 | ||
| */ | ||
| public static class LineColor { |
There was a problem hiding this comment.
因为这个东东归纳到哪里都不太对，索性就放到这个QrcodeService里头了。
binarywang
reviewed
Jul 27, 2017
| */ | ||
| File createWxCode(String path, int width, boolean autoColor, LineColor lineColor) throws WxErrorException; | ||
|
|
||
| File createWxCode(String path, int width) throws WxErrorException; |
| @@ -24,7 +24,7 @@ public static File createTmpFile(InputStream inputStream, String name, String ex | |||
| tmpFile = File.createTempFile(name, '.' + ext, tmpDirFile); | |||
| } | |||
|
|
|||
| tmpFile.deleteOnExit(); | |||
| // tmpFile.deleteOnExit(); | |||
There was a problem hiding this comment.
这个地方的临时文件是供调用方进一步处理的，建议退出java时删掉
binarywang
reviewed
Jul 27, 2017
| * lineColor 包装类 | ||
| * 用于描述二维码（小程序码）颜色（RGB参数值），详情请查看文档 | ||
| */ | ||
| public static class LineColor { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加小程序码支持，修正推送模板错误属性引发的NullPoint，增加TestCase