Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed where trying to mutate a non-existent value on null type clauses #18

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Fixed where trying to mutate a non-existent value on null type clauses #18

merged 1 commit into from
Nov 8, 2017

Conversation

dlett
Copy link

@dlett dlett commented Nov 8, 2017

Null type wheres do not have a value, and were throwing an undefined index exception.

@mtrpcic
Copy link

mtrpcic commented Nov 8, 2017

I approved but I also have no idea what I'm doing.

@bryanashley
Copy link
Contributor

I disagree.

@bryanashley
Copy link
Contributor

Nah this makes sense, but can you add a test showing it failing beforehand? @dlett

@bryanashley
Copy link
Contributor

Ah nevermind the builder class isnt tested at all, keep on livin your life.

@bryanashley bryanashley merged commit 7a48754 into Weebly:master Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrpcic mtrpcic mtrpcic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dlett @mtrpcic @bryanashley