Wherein subquery #27
Merged
Wherein subquery #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bezhermoso
requested changes
Jan 22, 2020
Co-Authored-By: Bez Hermoso <bezalelhermoso@gmail.com>
suadhuskic
reviewed
Jan 22, 2020
src/Database/EloquentBuilder.php
Outdated
| @@ -93,13 +93,24 @@ public function whereIn($column, $values, $boolean = 'and', $not = false) | |||
| return $this; | |||
| } | |||
|
|
|||
| // if ($where['type'] === 'In') { | |||
There was a problem hiding this comment.
can we remove this commented out code?
suadhuskic
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows using subqueries on a mutated field.
This also makes composer version constraints that will satisfy both laravel 5 and 6 when the lib is imported in apps that rely on one or the other.
@elliotfehr @bezhermoso @suadhuskic