Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two days can be selected after first or second Saturday is first selected #463

Closed
h-bomb opened this issue Oct 26, 2016 · 4 comments
Closed

Two days can be selected after first or second Saturday is first selected #463

h-bomb opened this issue Oct 26, 2016 · 4 comments
Labels
Fixed

Comments

@h-bomb
Copy link

h-bomb commented Oct 26, 2016 •
edited

In some cases, two days can be selected. This seems to only happen after the first or second Saturday is first selected (i.e., step 4). (Note that allowsMultipleSelection in the calendar is set to false).

Steps to reproduce in the current SwiftExample project (as of 10/25/2016):

  1. Download, then launch the SwiftExample project.
  2. Select either Interface Builder or LoadView.
  3. Swipe to October 2015.
  4. Tap Saturday, October 3rd.
  5. Swipe left to November 2015.
  6. Swipe right, back to October 2015.
  7. Tap any other date besides October 3rd.

Result:

Notice that both dates are selected.

screen shot 2016-10-25 at 8 33 49 pm
@WenchaoD
Copy link
Owner

Thanks for the detailed reporting @h-bomb . Will handle this ASAP.

@h-bomb
Copy link
Author

h-bomb commented Oct 26, 2016

Thanks so much, @WenchaoD...and for the great calendar! I have been modifying the calendar for a work project (and hope to do a pull request in the near future). I have been debugging the code, but haven't found the source of the issue yet. If you happen to know the source, I'd appreciate the info!

@h-bomb h-bomb changed the title Two days will be selected after first or second Saturday is first selected Two days can be selected after first or second Saturday is first selected Oct 26, 2016
WenchaoD added a commit that referenced this issue Oct 27, 2016
@WenchaoD
Fix issue #463
f471392
@WenchaoD
Copy link
Owner

Fixed

@h-bomb
Copy link
Author

h-bomb commented Oct 27, 2016

You are AWESOME, @WenchaoD! Thanks so much for fixing this so quickly! It appears to have resolved the issue.

@WenchaoD WenchaoD added the Fixed label Oct 27, 2016
WenchaoD added a commit that referenced this issue Oct 27, 2016
@WenchaoD
Fix issue #463
d49bf95
WenchaoD added a commit that referenced this issue Oct 28, 2016
@WenchaoD
Merge branch 'development'
be6c807 
* development:
  Replace private extension with NSCalendar category
  FSCalendarSeparators
  Fix issue #463
  Add ISSUE_TEMPLATE.md
  calendar.appearance.weekdayBackground
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@h-bomb @WenchaoD