Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the type hint for function mcar() in comments #157

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

yhzhu99
Copy link
Contributor

@yhzhu99 yhzhu99 commented Jul 13, 2023

Fix the type hint for function mcar() in comments

the mcar() function should return 4 values: (X_intact, X, missing_mask, indicating_mask) rather than the only X

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@WenjieDu
Copy link
Owner

Good! Let's merge it.

@WenjieDu WenjieDu merged commit a239d5a into WenjieDu:main Jul 13, 2023
1 of 2 checks passed
@WenjieDu
Copy link
Owner

Hi Yinghao @yhzhu99, thanks for your PR. You're very welcome to join us PyPOTS community. And if you're interested in becoming a maintainer of PyPOTS, please let me know. 😃

@yhzhu99
Copy link
Contributor Author

yhzhu99 commented Jul 17, 2023

Hi Wenjie,

Thank you so much for the warm welcome to the PyPOTS community. I'm truly honored to be invited as a maintainer. PyPOTS is an amazing project, and I admire the great work you and the team have put into it.

However, I wanted to be upfront about my availability. While I'm excited about the opportunity, I may not be able to maintain the project continuously due to time constraints. I would be happy to contribute and assist whenever possible, but I want to ensure that the project receives the attention it deserves from someone who can dedicate more time to it.

That being said, I genuinely wish PyPOTS continued success and growth. It's a valuable resource for the community, and I hope it thrives under your guidance. If there are specific areas where I can provide support, whether it's code reviews, feature development, or documentation, please let me know, and I'll do my best to contribute.

Additionally, I would like to share my currently active repository, ImputeEHR, which focuses on exploring effective imputation strategies for EHR data. You can find it at: https://github.com/yhzhu99/ImputeEHR.

While ImputeEHR is currently in its initial stage, my goal is to create a comprehensive benchmark that supports most kinds of imputation methods available in the market. One of the primary challenges we encounter with EHR datasets is the variable sequence length, as we have discussed in previous issues. By addressing this challenge and providing robust support, I believe we can have a significant impact on the field.

I understand that PyPOTS requires dedicated maintainers, and I want to make sure I'm transparent about my time constraints. However, if there are opportunities to collaborate or exchange ideas between PyPOTS and ImputeEHR, I would be thrilled to explore them further.

Once again, thank you for the invitation, and I look forward to being a part of the PyPOTS community.

Best regards,
Yinghao

@WenjieDu
Copy link
Owner

Great. Just saw your request on WeChat, let's chat instantly on it. BTW, you have been listed as one of PyPOTS contributors on the website. image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants