Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract latent from clustering models #192

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

WenjieDu
Copy link
Owner

What does this PR do?

Fixing #177

Before submitting

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@coveralls
Copy link
Collaborator

coveralls commented Sep 26, 2023

Pull Request Test Coverage Report for Build 6308606458

  • 33 of 34 (97.06%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.5%) to 83.625%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pypots/clustering/crli/model.py 11 12 91.67%
Files with Coverage Reduction New Missed Lines %
pypots/clustering/vader/model.py 1 88.57%
pypots/clustering/crli/model.py 2 93.33%
Totals Coverage Status
Change from base Build 6308599763: 0.5%
Covered Lines: 3585
Relevant Lines: 4287

💛 - Coveralls

@WenjieDu WenjieDu merged commit 28b9fdc into dev Sep 26, 2023
9 checks passed
@WenjieDu WenjieDu deleted the extract_latent_from_clustering_models branch September 26, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants