Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug in CRLI, switch to BSD-3 license #229

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Fix a bug in CRLI, switch to BSD-3 license #229

merged 2 commits into from
Nov 6, 2023

Conversation

WenjieDu
Copy link
Owner

@WenjieDu WenjieDu commented Nov 6, 2023

What does this PR do?

  1. fixing Issue about the updating strategy of term F in CRLI  #225;
  2. fixing Switch PyPOTS ecosystem license from GPL-v3 to BSD-3-Clause  #227;

Before submitting

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@WenjieDu
Fix the bug in the updating strategy of term F in CRLI (#226)
4989c7e 
* fix: keep the same strategy with the official TF implementation to update F;

* feat: enable CRLI to use val_set to select the best model;

* fix: remove old code from branch merging;

* fix: optimize imports;
@WenjieDu
Apply BSD-3 license, and update docs (#228)
e59ef4f 
* docs: fix some typos in docs;

* docs: update docs;

* feat: switch to BSD-3-Clause license;

* docs: update README;
@coveralls
Copy link
Collaborator

coveralls commented Nov 6, 2023 •
edited

Pull Request Test Coverage Report for Build 6765674629

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.009%) to 84.194%
Files with Coverage Reduction New Missed Lines %
pypots/clustering/crli/model.py 1 90.6%
Totals Coverage Status
Change from base Build 6703157405: 0.009%
Covered Lines: 4384
Relevant Lines: 5207
💛 - Coveralls

@WenjieDu WenjieDu merged commit 7577570 into main Nov 6, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WenjieDu @coveralls