Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if X_intact contains missing data for imputation models, check and list mismatched hyperparameters in the tuning mode #234

Merged
merged 5 commits into from
Nov 12, 2023

Conversation

WenjieDu
Copy link
Owner

What does this PR do?

  1. fixing For imputation models, X_intact in the val set containing missing data will cause NaN loss #232;
  2. fixing Check if tuning hyperparameters match with the model's arguments in the tuning mode #233;
  3. updating docs;

Before submitting

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@WenjieDu WenjieDu merged commit c962530 into main Nov 12, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant