Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactor #251

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Code refactor #251

merged 4 commits into from
Dec 1, 2023

Conversation

WenjieDu
Copy link
Owner

@WenjieDu WenjieDu commented Dec 1, 2023

What does this PR do?

Doing some code refactoring in this PR.

Before submitting

  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@coveralls
Copy link
Collaborator

coveralls commented Dec 1, 2023

Pull Request Test Coverage Report for Build 7061635412

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 274 of 320 (85.63%) changed or added relevant lines in 21 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 83.424%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pypots/modules/transformer/pos_enc.py 19 20 95.0%
pypots/imputation/csdi/modules/core.py 7 9 77.78%
pypots/imputation/gpvae/modules/core.py 24 29 82.76%
pypots/modules/transformer/layers.py 36 44 81.82%
pypots/modules/transformer/auto_encoder.py 14 44 31.82%
Totals Coverage Status
Change from base Build 7028983043: 0.05%
Covered Lines: 4469
Relevant Lines: 5357

💛 - Coveralls

@WenjieDu WenjieDu merged commit 191e777 into dev Dec 1, 2023
11 of 12 checks passed
@WenjieDu WenjieDu deleted the code_refactor branch December 1, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants