Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding TimesNet as an imputation model #252

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Adding TimesNet as an imputation model #252

merged 1 commit into from
Dec 1, 2023

Conversation

WenjieDu
Copy link
Owner

@WenjieDu WenjieDu commented Dec 1, 2023

What does this PR do?

Fixing #250;

Before submitting

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@WenjieDu WenjieDu changed the base branch from main to dev December 1, 2023 15:27
@WenjieDu WenjieDu closed this Dec 1, 2023
@WenjieDu WenjieDu reopened this Dec 1, 2023
@coveralls
Copy link
Collaborator

coveralls commented Dec 1, 2023

Pull Request Test Coverage Report for Build 7062000341

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 240 of 265 (90.57%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 83.793%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pypots/imputation/timesnet/modules/layer.py 63 66 95.45%
pypots/imputation/timesnet/model.py 67 74 90.54%
pypots/imputation/timesnet/modules/embedding.py 58 73 79.45%
Totals Coverage Status
Change from base Build 7061808206: 0.4%
Covered Lines: 4710
Relevant Lines: 5621

💛 - Coveralls

@WenjieDu WenjieDu merged commit f3dfec7 into dev Dec 1, 2023
12 checks passed
@WenjieDu WenjieDu deleted the add_timesnet branch December 1, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants