Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing unstable nonstationary norm, adding utils.visual, and doing some code refactoring #266

Merged
merged 7 commits into from
Dec 14, 2023

Conversation

WenjieDu
Copy link
Owner

@WenjieDu WenjieDu commented Dec 11, 2023

What does this PR do?

  1. add pypots.nn package and pypots.nn.functional;
  2. rename pypots.modules into pypots.nn.modules;
  3. add pypots.utils.visual package;
  4. fix Current non-stationary normalization may result in NaN values #265;

Before submitting

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@WenjieDu WenjieDu changed the title Fixing unstable nonstationary norm, and doing some refactor Fixing unstable nonstationary norm, and doing some code refactoring Dec 11, 2023
AugustJW and others added 3 commits December 12, 2023 11:48
add two visualisation functions in utils
Adding visualization functions
* Create visualization.py

* Update visualization.py

---------

Co-authored-by: Wenjie Du <wenjay.du@gmail.com>
@WenjieDu WenjieDu changed the title Fixing unstable nonstationary norm, and doing some code refactoring Fixing unstable nonstationary norm, adding utils.visual, and doing some code refactoring Dec 12, 2023
@coveralls
Copy link
Collaborator

coveralls commented Dec 12, 2023

Pull Request Test Coverage Report for Build 7178090015

  • 24 of 179 (13.41%) changed or added relevant lines in 14 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.1%) to 80.875%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pypots/imputation/timesnet/modules/core.py 5 7 71.43%
pypots/nn/functional/normalization.py 5 30 16.67%
pypots/utils/visual.py 0 54 0.0%
pypots/utils/visualization.py 0 74 0.0%
Totals Coverage Status
Change from base Build 7157280175: -2.1%
Covered Lines: 4808
Relevant Lines: 5945

💛 - Coveralls

@WenjieDu WenjieDu merged commit e2dc211 into main Dec 14, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current non-stationary normalization may result in NaN values
4 participants