Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifying the structure of val_set, and using a consistent strategy when lazy-loading val_set #272

Merged
merged 16 commits into from
Dec 18, 2023

Conversation

WenjieDu
Copy link
Owner

What does this PR do?

  1. fixing Simplify the structure of val_set #271;
  2. fixing Make the framework using a consistent strategy when lazy-loading val_set #270;

Before submitting

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@coveralls
Copy link
Collaborator

coveralls commented Dec 18, 2023

Pull Request Test Coverage Report for Build 7243404330

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 263 of 319 (82.45%) changed or added relevant lines in 31 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.5%) to 82.933%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pypots/data/checking.py 9 10 90.0%
pypots/imputation/brits/model.py 8 9 88.89%
pypots/imputation/csdi/model.py 9 10 90.0%
pypots/imputation/gpvae/model.py 8 9 88.89%
pypots/imputation/mrnn/model.py 8 9 88.89%
pypots/imputation/saits/model.py 7 8 87.5%
pypots/imputation/timesnet/model.py 7 8 87.5%
pypots/imputation/transformer/model.py 7 8 87.5%
pypots/imputation/usgan/model.py 8 9 88.89%
pypots/data/utils.py 6 9 66.67%
Files with Coverage Reduction New Missed Lines %
pypots/classification/base.py 1 74.07%
pypots/classification/brits/model.py 3 95.31%
pypots/data/saving/h5.py 3 81.48%
Totals Coverage Status
Change from base Build 7219615511: 0.5%
Covered Lines: 4937
Relevant Lines: 5953

💛 - Coveralls

@WenjieDu WenjieDu merged commit 0a02cda into dev Dec 18, 2023
22 checks passed
@WenjieDu WenjieDu deleted the temp_test_branch branch December 18, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants