Adding _check_inputs() for error calculation functions #279

WenjieDu · 2023-12-21T10:13:13Z

What does this PR do?

Adding a unified func _check_inputs() to help check inputs' values and shapes for error calculation functions.

Before submitting

This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
I have commented my code, particularly in hard-to-understand areas.
I have written necessary tests and already run them locally.

…during torch training will raise error... RuntimeError: Can't call numpy() on Tensor that requires grad. Use tensor.detach().numpy() instead.

WenjieDu added 3 commits December 21, 2023 16:53

feat: add _check_inputs() for all error metric calculation functions;

a85e302

fix: use corresponding lib to detect NaN, otherwise loss calculation …

d2a475a

…during torch training will raise error... RuntimeError: Can't call numpy() on Tensor that requires grad. Use tensor.detach().numpy() instead.

fix: don't check shapes for CRPS calc funcs;

b6858eb

WenjieDu merged commit 9c5c380 into dev Dec 21, 2023
9 of 23 checks passed

WenjieDu deleted the add_check_inputs branch December 21, 2023 11:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding _check_inputs() for error calculation functions #279

Adding _check_inputs() for error calculation functions #279

WenjieDu commented Dec 21, 2023

Adding _check_inputs() for error calculation functions #279

Adding _check_inputs() for error calculation functions #279

Conversation

WenjieDu commented Dec 21, 2023

What does this PR do?

Before submitting