Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing CSDI, adding placeholder for epoch num in logging #280

Merged
merged 5 commits into from
Dec 22, 2023
Merged

Conversation

WenjieDu
Copy link
Owner

What does this PR do?

  1. fix the bug that val_set didn't return X_ori in CSDI;
  2. add 0s placeholder for epoch number in logging;
  3. ensure n_sampling_times>0 for CSDI and GP-VAE predict();

Before submitting

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@coveralls
Copy link
Collaborator

coveralls commented Dec 22, 2023

Pull Request Test Coverage Report for Build 7298098181

  • 12 of 19 (63.16%) changed or added relevant lines in 9 files are covered.
  • 7 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.1%) to 81.809%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pypots/classification/base.py 0 1 0.0%
pypots/clustering/base.py 0 1 0.0%
pypots/clustering/vader/model.py 0 1 0.0%
pypots/forecasting/base.py 0 1 0.0%
pypots/imputation/base.py 0 1 0.0%
pypots/imputation/csdi/model.py 2 3 66.67%
pypots/imputation/gpvae/model.py 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
pypots/classification/base.py 1 74.07%
pypots/clustering/base.py 1 38.0%
pypots/clustering/vader/model.py 1 85.28%
pypots/forecasting/base.py 1 35.24%
pypots/imputation/base.py 1 76.85%
pypots/imputation/csdi/model.py 1 83.72%
pypots/imputation/gpvae/model.py 1 86.01%
Totals Coverage Status
Change from base Build 7291907623: 0.1%
Covered Lines: 5091
Relevant Lines: 6223

💛 - Coveralls

@WenjieDu WenjieDu merged commit 4e3fbb0 into dev Dec 22, 2023
6 of 12 checks passed
@WenjieDu WenjieDu deleted the refactor_csdi branch December 25, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants