Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues in MRNN and update the hyperparameter tuning functionality #288

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Fix issues in MRNN and update the hyperparameter tuning functionality #288

merged 3 commits into from
Dec 27, 2023

Conversation

WenjieDu
Copy link
Owner

What does this PR do?

  1. fixing Bug in MRNN, the model should iterate on each feature #283 and speeding up MRNN;
  2. updating the tuning functionality;

Before submitting

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@WenjieDu
feat: make the tuning function set random seed and log new hyperparam…
12b02aa 
…eters;
@WenjieDu
Fixing MRNN (#286)
1d61ac0 
* feat: let pytest print detail logs during testing;

* fix: make MRNN run on each feature;

* fix: calculate RMSE between full FCN_estimation and RNN_imputed_data;

* fix: update delta calculation in MRNN dataset;
@WenjieDu
refactor: use torch GRU in MRNN to speed up;
e7e172a
@WenjieDu WenjieDu merged commit 49a2a9e into main Dec 27, 2023
6 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@WenjieDu