Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding KeyboardInterrupt handler for downloading process, and updating workflows #22

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

WenjieDu
Copy link
Owner

What does this PR do?

  1. fixing ERR path not found caused by interrupted downloading #21;
  2. updating workflows;

Before submitting

  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@aaanh
Copy link

aaanh commented Jul 28, 2023

Exception handling looks good, but the CI test pipelines are failing due to shutil unable to read the dataset zip file (I think?). Might need to solve this before merging. Or if you don't think it matters and should open another issue to investigate, we can go ahead and merge.

@WenjieDu
Copy link
Owner Author

Failing is due to changed download links of UCR&UEA datasets. For example, they have changed the download link of Beef dataset from https://www.timeseriesclassification.com/ClassificationDownloads/Beef.zip to https://timeseriesclassification.com/aeon-toolkit/Beef.zip. This has happened twice recently.

@aaanh
Copy link

aaanh commented Jul 28, 2023

Cool, got it. I couldn't even find the actual Beef.zip dataset download link on the information page 😅
Other than that, I think you're good to merge!

@WenjieDu
Copy link
Owner Author

Have raised issue #23 for the next round PR.

@WenjieDu WenjieDu merged commit 97f8ff7 into main Jul 28, 2023
3 of 15 checks passed
WenjieDu added a commit that referenced this pull request Aug 6, 2023
Adding KeyboardInterrupt handler for downloading process, and updating workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants