Unit tests #82
Unit tests #82
Conversation
|
Do not merge until previous ones have been merged! |
arnabcs17b006
force-pushed
the
unit_tests
branch
4 times, most recently
from
dae0ece
to
d08437a
Compare
|
@arnabcs17b006 same question here ? |
|
Yes.. It is relevant
…On Thu, Aug 20, 2020, 04:37 Mathieu Tarral ***@***.***> wrote:
@arnabcs17b006 <https://github.com/arnabcs17b006> same question here ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#82 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALGMDC5ZGNQLMANLOT3RMNLSBRLLFANCNFSM4OEQPDLQ>
.
|
|
Then I think you need a rebase too |
arnabcs17b006
force-pushed
the
unit_tests
branch
3 times, most recently
from
ae797c1
to
819f58e
Compare
|
You should not change anything in the existing tests. They are fine as there are right now. Even worse, your changes to them are causing runtime errors. |
|
Looks like you have not addressed any comments from my previous review. |
arnabcs17b006
force-pushed
the
unit_tests
branch
from
819f58e
to
a809d41
Compare
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
===========================================
+ Coverage 16.73% 69.09% +52.35%
===========================================
Files 5 5
Lines 472 990 +518
Branches 65 104 +39
===========================================
+ Hits 79 684 +605
+ Misses 382 219 -163
- Partials 11 87 +76
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
arnabcs17b006
force-pushed
the
unit_tests
branch
from
a809d41
to
32187f0
Compare
arnabcs17b006
force-pushed
the
unit_tests
branch
4 times, most recently
from
6501bc4
to
327a40d
Compare
arnabcs17b006
force-pushed
the
unit_tests
branch
from
1f01abb
to
f790ce9
Compare
arnabcs17b006
force-pushed
the
unit_tests
branch
2 times, most recently
from
d4e3fd9
to
dec56ae
Compare
src/driver/kvm.rs
Outdated
| ) | ||
| .times(1) | ||
| .returning(|_, _, _| Ok(())); | ||
| kvmi_mock |
There was a problem hiding this comment.
@Wenzel is it logically possible for toggling pagefault interception on to fail if called a second time?
arnabcs17b006
force-pushed
the
unit_tests
branch
5 times, most recently
from
03ecf33
to
2947879
Compare
arnabcs17b006
force-pushed
the
unit_tests
branch
from
2947879
to
51d3d67
Compare
Do not merge until previous ones are merged!