Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extension for new markdown version #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Wainggan
Copy link

@Wainggan Wainggan commented Sep 13, 2023

I'm going to be completely honest, I haven't a single clue as to what I'm doing, this is my first attempt at contributing to anything.
The extension didn't seem to work with the markdown library anymore, so here is my attempt to fix it. Feedback would be sincerely appreciated.

@Wainggan Wainggan changed the title Update extension for new Markdown version Update extension for new markdown version Sep 13, 2023
@paolini
Copy link

paolini commented Jan 5, 2024

You pass 0 as priority. In the previous version priority was described as ">raw_html". I have checked that raw_html has priority 20. I wonder if 0 is correct or 30 should be used.

@Wenzil are you willing to update the package?

this would solve issue #7

@Wainggan
Copy link
Author

Wainggan commented Jan 6, 2024

I wasn't aware that ">raw_html" meant anything like that, so I chose 0 because it worked with my (albeit basic) tests. If raw_html originally resolved to 20, it would probably be a good idea to edit 0 to something that fits around that better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants