Skip to content

Commit

Permalink
more CONTRIBUTING.md
Browse files Browse the repository at this point in the history
  • Loading branch information
jhunpingco committed Nov 1, 2021
1 parent 6c33683 commit c694ce4
Showing 1 changed file with 10 additions and 8 deletions.
18 changes: 10 additions & 8 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@

Here are some guidelines for pull requests:

* All work is submitted via Pull Requests.
* Pull Requests can be submitted as soon as there is code worth discussing. The worst case is that the PR is closed.
* Pull Requests should be made against master
* Pull Requests should be tested, if feasible:
- bugfixes should include regression tests.
- new behavior should at least get minimal exercise.
- new features should include a screenshot
* Don't make 'cleanup' pull requests just to change code style. We don't follow any style guide strictly, and we consider formatting changes unnecessary noise. If you're making functional changes, you can clean up the specific pieces of code you're working on.
* All work is submitted via Pull Requests.
* Pull Requests can be submitted as soon as there is code worth discussing. The worst case is that the PR is closed.
* Pull Requests should be made against master
* Pull Requests should be tested, if feasible:
- bugfixes should include regression tests.
- new behavior should at least get minimal exercise.
- new features should include a screenshot
* Don't make 'cleanup' pull requests just to change code style. We don't follow any style guide strictly, and we consider formatting changes unnecessary noise. If you're making functional changes, you can clean up the specific pieces of code you're working on.

Pyvis wraps vis.js so JavaScript functionality issues should be directed at the main `vis.js` project.

0 comments on commit c694ce4

Please sign in to comment.