Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

st1206: implement Local set for SAR motion imagery #247

Merged
merged 1 commit into from Nov 12, 2020

Conversation

bradh
Copy link
Collaborator

@bradh bradh commented Oct 18, 2020

Motivation and Context

This is a ST0601 nested local set that we don't currently support.

Resolves #166
Relates #198

Description

Full implementation of ST 1206.1
Also implement ST 1403.2 SARMI Minimum Metadata validation. That is useful because the test tools don't check this part completely.
Also added SARMI to generator example. There are some minor cleanups mixed into that, because I got a new CMITT which showed new problems during test.
Includes initial work on ST 1303 for floating point values. That in turn required extensions to the PrimitiveConverter code, which also got some more unit tests for existing code.

How Has This Been Tested?

There is no public / releasable test data that I know of - asked MISB, but not expecting a positive answer.
I did extend the generator example to output SAR Motion Imagery metadata, and pushed that through CMITT. It passes, but I don't think CMITT is checking all the values, so that is of limited confidence. Better than nothing though.
There is good unit test coverage.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Also implement ST 1403 SARMI Minimum Metadata validation.
Also add SARMI to generator example. There are some minor cleanups mixed into that, because I got a new CMITT which showed new problems during test.
Includes initial work on ST 1303 for floating point values. That in turn required extensions to the PrimitiveConverter code, which also got some more unit tests for existing code.
@bradh bradh marked this pull request as ready for review October 18, 2020 10:51
@wlfgang wlfgang merged commit 558e865 into WestRidgeSystems:develop Nov 12, 2020
@bradh bradh deleted the st1206merge branch November 13, 2020 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ST0601: SarMotionImageryMetadata support
2 participants