st1303: implement additional encode and decode #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Boolean 1D decoding (Natural Format, Boolean Array, Run length encoding) - Boolean 1D encoding (Natural Format, Boolean Array) - Floating Point 1D decoding (Run length encoding) - Floating Point 2D decoding (Run length encoding) - Signed 1D integer decoding (Run length encoding) - Signed 2D integer decoding (Run length encoding) - Unsigned 1D integer decoding (Run length encoding) - Unsigned 2D integer decoding (Run length encoding)
Codecov Report
@@ Coverage Diff @@
## 2.x #391 +/- ##
============================================
+ Coverage 90.91% 91.04% +0.13%
- Complexity 5580 5644 +64
============================================
Files 613 613
Lines 14731 14956 +225
Branches 1357 1394 +37
============================================
+ Hits 13392 13617 +225
Misses 1291 1291
Partials 48 48
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Adds implementations for ST 1303 Multi Dimensional Array Pack that we don't yet support.
The decoding is important for interoperability in case someone decides to use that. The Boolean 1D stuff is just for completeness (and is probably not useful).
Resolves #198 (which I've dropped RLE encoding - as opposed to decoding - support out of - its difficult to do in general, and probably requires domain-specific knowledge of the nature of the data being encoded to be really efficient).
Description
Adds implementations consistent with existing code. Updated documentation and tests.
How Has This Been Tested?
Unit tests only. The test cases from ST 1303.2 are now used.
Screenshots (if appropriate):
N/A.
Types of changes
Checklist: