Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create intermediary block representation for test visibility #632

Merged
merged 15 commits into from
Jun 3, 2023

Conversation

brylie
Copy link
Member

@brylie brylie commented May 30, 2023

Closes #631

copilot:all

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage: 93.59% and project coverage change: +0.31 🎉

Comparison is base (24d234e) 86.54% compared to head (429f79e) 86.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
+ Coverage   86.54%   86.86%   +0.31%     
==========================================
  Files         240      243       +3     
  Lines        3827     3950     +123     
==========================================
+ Hits         3312     3431     +119     
- Misses        515      519       +4     
Impacted Files Coverage Δ
...pp/content_migration/management/commands/shared.py 95.78% <87.50%> (+4.81%) ⬆️
...ontent_migration/management/commands/conversion.py 87.62% <87.62%> (ø)
...content_migration/management/commands/constants.py 100.00% <100.00%> (ø)
...pp/content_migration/management/commands/errors.py 100.00% <100.00%> (ø)
...t_migration/management/commands/test_conversion.py 100.00% <100.00%> (ø)
...ntent_migration/management/commands/test_shared.py 98.75% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@brylie brylie marked this pull request as ready for review May 31, 2023 17:08
@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Jun 3, 2023

Code Climate has analyzed commit 429f79e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 93.6% (50% is the threshold).

This pull request will bring the total coverage in the repository to 86.8%.

View more on Code Climate.

@brylie brylie merged commit 9f2875e into main Jun 3, 2023
7 checks passed
@brylie brylie deleted the refactor-design-patterns branch June 3, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try creating adapter and factor for parsing HTML content
1 participant