Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module sizing options #380

Closed
11 tasks done
jonnystening opened this issue Sep 13, 2017 · 5 comments
Closed
11 tasks done

Module sizing options #380

jonnystening opened this issue Sep 13, 2017 · 5 comments
Assignees

Comments

@jonnystening
Copy link
Contributor

jonnystening commented Sep 13, 2017

We’re bringing in a new consistent classing convention going forward... .module-[xsmall|small|large|xlarge] to denote appearance sizing and [xs|sm|md|lg|xl] to denote breakpoint. That way we won’t have uber confusing class names like .btn-sm-sm. This example would be .btn-small-sm, meaning "button is sized small at the sm breakpoint".

('medium' will be the default size and not explicitly required via a '.btn-medium' class)

This new naming approach will affect buttons, icons, modals etc. We will update the Icons module to begin with (as part of #360), also referenced by Alerts and Buttons (as icons can be placed in either).

The following modules will need updating to utilise this new naming convention...

  • Icons
  • Buttons
  • Input Addons (now Input Groups)
  • Input Fields
  • Input Groups
  • Modals
  • Switches
  • Badges (buttons)
  • Alerts (icons)
  • Symbols
  • Tooltips (icons)

Docs will also need to be updated as per #223

@jonnystening
Copy link
Contributor Author

Closed by a number of commits. Love to link you through to them all, but nah soz.

@justinspencer
Copy link
Contributor

I'm assuming Input Addons is now Input Groups

@justinspencer
Copy link
Contributor

Alerts close icon. Please use the contextual colour. For example the info close icon is blue. See Sketch file for reference.

@justinspencer
Copy link
Contributor

Alerts select menu. The caret is missing.

@jonnystening
Copy link
Contributor Author

@justinspencer caret was only missing on the testing page, was all good, but now fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants